diff options
| author | Roan Kattouw <roan.kattouw@gmail.com> | 2014-12-15 16:34:21 +0100 |
|---|---|---|
| committer | Giuseppe Lavagetto <glavagetto@wikimedia.org> | 2014-12-15 16:07:55 +0000 |
| commit | 016d617bc302c76e5f728518d77dfa7bd8c086b3 (patch) | |
| tree | 6495e61f026d04fd61305ac129699d4b9529bac8 /includes/media/TransformationalImageHandler.php | |
| parent | 5ee76a90eb4733588cce232fddd7f6c618394b14 (diff) | |
| download | mediawikicore-016d617bc302c76e5f728518d77dfa7bd8c086b3.tar.gz mediawikicore-016d617bc302c76e5f728518d77dfa7bd8c086b3.zip | |
Followup cf5f641: pass $params by reference again
&$params was changed to $params, but hooks.txt still documents
this parameter as being passed by reference, and VipsScaler expects this.
Giuseppe and I suspect this may be what's causing the HHVM segfaults
we're seeing in beta labs.
Change-Id: Ib018f23bc44c247aefc277a0c75ff8577f309ab4
Diffstat (limited to 'includes/media/TransformationalImageHandler.php')
| -rw-r--r-- | includes/media/TransformationalImageHandler.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/media/TransformationalImageHandler.php b/includes/media/TransformationalImageHandler.php index 51cd28d2c8b1..fd8d81d24c2e 100644 --- a/includes/media/TransformationalImageHandler.php +++ b/includes/media/TransformationalImageHandler.php @@ -589,14 +589,14 @@ abstract class TransformationalImageHandler extends ImageHandler { * @return bool * @since 1.25 */ - public function isImageAreaOkForThumbnaling( $file, $params ) { + public function isImageAreaOkForThumbnaling( $file, &$params ) { global $wgMaxImageArea; # For historical reasons, hook starts with BitmapHandler $checkImageAreaHookResult = null; Hooks::run( 'BitmapHandlerCheckImageArea', - array( $file, $params, &$checkImageAreaHookResult ) + array( $file, &$params, &$checkImageAreaHookResult ) ); if ( !is_null( $checkImageAreaHookResult ) ) { |