diff options
author | Umherirrender <umherirrender_de.wp@web.de> | 2021-08-28 10:40:44 +0200 |
---|---|---|
committer | Umherirrender <umherirrender_de.wp@web.de> | 2021-09-07 17:19:05 +0200 |
commit | 07b499fbcf8f1590d70c8dbe38ab0513d6d19738 (patch) | |
tree | 37c81dc92a8fd9bdd72009a424e73d0a5ba2c887 /includes/logging | |
parent | 695db680207e965fe062d4aec3938aa35b8fbd1f (diff) | |
download | mediawikicore-07b499fbcf8f1590d70c8dbe38ab0513d6d19738.tar.gz mediawikicore-07b499fbcf8f1590d70c8dbe38ab0513d6d19738.zip |
build: Update mediawiki/mediawiki-phan-config to 0.11.0
Addition and remove of suppression needs to be done with the version
update.
Change-Id: I3288b3cefa744b507eadebb67b8ab08c86517c1c
Diffstat (limited to 'includes/logging')
-rw-r--r-- | includes/logging/BlockLogFormatter.php | 2 | ||||
-rw-r--r-- | includes/logging/LogEventsList.php | 1 | ||||
-rw-r--r-- | includes/logging/LogPage.php | 2 | ||||
-rw-r--r-- | includes/logging/PatrolLogFormatter.php | 1 | ||||
-rw-r--r-- | includes/logging/RightsLogFormatter.php | 1 | ||||
-rw-r--r-- | includes/logging/TagLogFormatter.php | 2 |
6 files changed, 4 insertions, 5 deletions
diff --git a/includes/logging/BlockLogFormatter.php b/includes/logging/BlockLogFormatter.php index d724d8cb0f41..d975dea7f77f 100644 --- a/includes/logging/BlockLogFormatter.php +++ b/includes/logging/BlockLogFormatter.php @@ -58,6 +58,7 @@ class BlockLogFormatter extends LogFormatter { // in English to help visitors from other wikis. // The lrm is needed to make sure that the number // is shown on the correct side of the tooltip text. + // @phan-suppress-next-line SecurityCheck-DoubleEscaped $durationTooltip = '‎' . htmlspecialchars( $params[4] ); $blockExpiry = $this->context->getLanguage()->translateBlockExpiry( $params[4], @@ -65,7 +66,6 @@ class BlockLogFormatter extends LogFormatter { wfTimestamp( TS_UNIX, $this->entry->getTimestamp() ) ); if ( $this->plaintext ) { - // @phan-suppress-next-line SecurityCheck-XSS Plain text $params[4] = Message::rawParam( $blockExpiry ); } else { $params[4] = Message::rawParam( diff --git a/includes/logging/LogEventsList.php b/includes/logging/LogEventsList.php index 1a8120f92952..2d4742f5d6a5 100644 --- a/includes/logging/LogEventsList.php +++ b/includes/logging/LogEventsList.php @@ -666,6 +666,7 @@ class LogEventsList extends ContextSource { if ( $param['useMaster'] ) { $pager->mDb = wfGetDB( DB_PRIMARY ); } + // @phan-suppress-next-line PhanImpossibleCondition if ( isset( $param['offset'] ) ) { # Tell pager to ignore WebRequest offset $pager->setOffset( $param['offset'] ); } diff --git a/includes/logging/LogPage.php b/includes/logging/LogPage.php index 00b1314c01c7..c3e0e71ad417 100644 --- a/includes/logging/LogPage.php +++ b/includes/logging/LogPage.php @@ -255,7 +255,6 @@ class LogPage { $titleLink = self::getTitleLink( $title, $langObjOrNull ); if ( count( $params ) == 0 ) { - // @phan-suppress-next-line SecurityCheck-XSS mixed between plaintext and html $rv = wfMessage( $wgLogActions[$key] )->rawParams( $titleLink ) ->inLanguage( $langObj )->escaped(); } else { @@ -270,6 +269,7 @@ class LogPage { if ( isset( $wgLogActionsHandlers[$key] ) ) { $args = func_get_args(); + // @phan-suppress-next-line PhanTypeMismatchArgumentInternal $rv = call_user_func_array( $wgLogActionsHandlers[$key], $args ); } else { wfDebug( "LogPage::actionText - unknown action $key" ); diff --git a/includes/logging/PatrolLogFormatter.php b/includes/logging/PatrolLogFormatter.php index 8cc842ffe56c..97d7289a1e40 100644 --- a/includes/logging/PatrolLogFormatter.php +++ b/includes/logging/PatrolLogFormatter.php @@ -59,7 +59,6 @@ class PatrolLogFormatter extends LogFormatter { $revlink = htmlspecialchars( $revision ); } - // @phan-suppress-next-line SecurityCheck-XSS one if branch is for plain text $params[3] = Message::rawParam( $revlink ); return $params; diff --git a/includes/logging/RightsLogFormatter.php b/includes/logging/RightsLogFormatter.php index d2a17cca62b9..dd8014051c89 100644 --- a/includes/logging/RightsLogFormatter.php +++ b/includes/logging/RightsLogFormatter.php @@ -40,6 +40,7 @@ class RightsLogFormatter extends LogFormatter { $parts = explode( $wgUserrightsInterwikiDelimiter, $text, 2 ); if ( count( $parts ) === 2 ) { + // @phan-suppress-next-line SecurityCheck-DoubleEscaped $titleLink = WikiMap::foreignUserLink( $parts[1], $parts[0], diff --git a/includes/logging/TagLogFormatter.php b/includes/logging/TagLogFormatter.php index ab6b5ea7a2a7..1241c17ade8b 100644 --- a/includes/logging/TagLogFormatter.php +++ b/includes/logging/TagLogFormatter.php @@ -61,10 +61,8 @@ class TagLogFormatter extends LogFormatter { } if ( $isRevLink ) { - // @phan-suppress-next-line SecurityCheck-XSS one if branch is for plain text $params[3] = Message::rawParam( $link ); } else { - // @phan-suppress-next-line SecurityCheck-XSS one if branch is for plain text $params[4] = Message::rawParam( $link ); } |