diff options
| author | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2019-01-09 17:24:36 +0100 |
|---|---|---|
| committer | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2019-01-15 17:28:49 +0100 |
| commit | 734a969d5506a80ceabfa2bc61bda79f76d73d5f (patch) | |
| tree | eaa619f76fce39e07f8e755593bb0cd7c80520ad /includes/libs/rdbms/database/Database.php | |
| parent | a4880e9bbfd90642cfa5b852bdabf4101760f092 (diff) | |
| download | mediawikicore-734a969d5506a80ceabfa2bc61bda79f76d73d5f.tar.gz mediawikicore-734a969d5506a80ceabfa2bc61bda79f76d73d5f.zip | |
Safe replacement of a lot of `!count()` with `=== []`
This was originally a global search and replace. I manually checked all
replacements and reverted them if (due to the lack of type hints) either
null (that would be 0 when counted) or a Countable object can end in the
variable or property in question.
Now this patch only touches places where I'm sure nothing can break.
For the sanity of the honorable reviewers this patch is exclusively touching
negated counts. You should not find a single `!== []` in this patch, that
would be a mistake.
Change-Id: I5eafd4d8fccdb53a668be8e6f25a566f9c3a0a95
Diffstat (limited to 'includes/libs/rdbms/database/Database.php')
| -rw-r--r-- | includes/libs/rdbms/database/Database.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php index 9a9e36ac6f82..7d971af9297f 100644 --- a/includes/libs/rdbms/database/Database.php +++ b/includes/libs/rdbms/database/Database.php @@ -2855,7 +2855,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware public function upsert( $table, array $rows, array $uniqueIndexes, array $set, $fname = __METHOD__ ) { - if ( !count( $rows ) ) { + if ( $rows === [] ) { return true; // nothing to do } |