diff options
author | Tim Starling <tstarling@wikimedia.org> | 2022-11-09 11:47:13 +1100 |
---|---|---|
committer | Tim Starling <tstarling@wikimedia.org> | 2022-11-09 12:57:23 +1100 |
commit | 0b12f8b69880d108db9035176532c891e8a75f79 (patch) | |
tree | 7828406885aa27acb7958e7e652c76986b1b7c03 /includes/libs/filebackend/exception | |
parent | ebd13491b7595fe113106822fd2e7eec70eb0eb9 (diff) | |
download | mediawikicore-0b12f8b69880d108db9035176532c891e8a75f79.tar.gz mediawikicore-0b12f8b69880d108db9035176532c891e8a75f79.zip |
Improve LocalisationCache post-merge validation check
When I deleted MessagesEn.php, neither the exception on line 498 nor
the exception modified here was thrown. Extensions register namespaces,
hiding the lack of default namespaces. If namespaceNames was missing,
RHS line 1004 would raise a warning but would create the key.
Also, phan was complaining that the key might be absent.
So, use 'rtl' instead of 'namespaceNames' as our test for data validity,
since it's less likely to be overridden by extensions. Move the check up
above the normalization of individual keys. Use isset() to satisfy phan.
Bug: T322278
Change-Id: I44c7506205fbe9ba6ffbd1155a6cdcf3ff0960eb
Diffstat (limited to 'includes/libs/filebackend/exception')
0 files changed, 0 insertions, 0 deletions