diff options
| author | Umherirrender <umherirrender_de.wp@web.de> | 2022-03-28 22:10:05 +0200 |
|---|---|---|
| committer | Umherirrender <umherirrender_de.wp@web.de> | 2022-03-28 23:26:49 +0200 |
| commit | 7aa0884029ea59d2c974b1fe850b1b6edd4dc5a5 (patch) | |
| tree | 9791a3d8596f8db1163e05f484e2616a39bd7432 /includes/http/MWHttpRequest.php | |
| parent | 991980fc8a9ee4363d10c6a2aa7cc228c863d856 (diff) | |
| download | mediawikicore-7aa0884029ea59d2c974b1fe850b1b6edd4dc5a5.tar.gz mediawikicore-7aa0884029ea59d2c974b1fe850b1b6edd4dc5a5.zip | |
phan: Remove PhanTypePossiblyInvalidDimOffset suppression
Make phan stricter about array keys
Remaining false positive issues are suppressed.
The suppression and the setting change can only be done together
Bug: T304887
Depends-On: I3105a5fd4826f8667b5232834defc5ec93be32a1
Depends-On: Ie9610a6e83731468311edb3ed17f80fc509de385
Change-Id: I701f12ab94478c3b8e7fd82110ade74a8e6b04ef
Diffstat (limited to 'includes/http/MWHttpRequest.php')
| -rw-r--r-- | includes/http/MWHttpRequest.php | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/includes/http/MWHttpRequest.php b/includes/http/MWHttpRequest.php index 3ac63d258c42..a01f5b01b86f 100644 --- a/includes/http/MWHttpRequest.php +++ b/includes/http/MWHttpRequest.php @@ -150,6 +150,7 @@ abstract class MWHttpRequest implements LoggerAwareInterface { // ensure that MWHttpRequest::method is always // uppercased. T38137 if ( $o == 'method' ) { + // @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive $options[$o] = strtoupper( $options[$o] ); } $this->$o = $options[$o]; |