diff options
| author | Func <Funcer@outlook.com> | 2022-02-20 15:14:50 +0000 |
|---|---|---|
| committer | Func <Funcer@outlook.com> | 2022-02-20 15:17:49 +0000 |
| commit | a745a87216fe16a456917ec2e5bb11972d7762cc (patch) | |
| tree | 6664dc7b4dadead2182b1326e9226a67dab4e39a /includes/htmlform | |
| parent | 0c8c75436ca21e1b83226583f84cdc84a006048a (diff) | |
| download | mediawikicore-a745a87216fe16a456917ec2e5bb11972d7762cc.tar.gz mediawikicore-a745a87216fe16a456917ec2e5bb11972d7762cc.zip | |
htmlform: Replace some uses of isHidden to isDisabled
After its logic is refactored, we have more faith to use isDisabled() in these cases, which matches the original semantics of isHidden().
Change-Id: I1aece7c691307ac8bb3770e6dc4b8e2877e4d65c
Diffstat (limited to 'includes/htmlform')
| -rw-r--r-- | includes/htmlform/HTMLFormField.php | 2 | ||||
| -rw-r--r-- | includes/htmlform/fields/HTMLFormFieldCloner.php | 2 | ||||
| -rw-r--r-- | includes/htmlform/fields/HTMLRestrictionsField.php | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/includes/htmlform/HTMLFormField.php b/includes/htmlform/HTMLFormField.php index 01a6ac1e45e1..97fdf718b2b1 100644 --- a/includes/htmlform/HTMLFormField.php +++ b/includes/htmlform/HTMLFormField.php @@ -395,7 +395,7 @@ abstract class HTMLFormField { * false to fail validation without displaying an error. */ public function validate( $value, $alldata ) { - if ( $this->isHidden( $alldata ) ) { + if ( $this->isDisabled( $alldata ) ) { return true; } diff --git a/includes/htmlform/fields/HTMLFormFieldCloner.php b/includes/htmlform/fields/HTMLFormFieldCloner.php index 8ae114548e92..5309b4369b1a 100644 --- a/includes/htmlform/fields/HTMLFormFieldCloner.php +++ b/includes/htmlform/fields/HTMLFormFieldCloner.php @@ -351,7 +351,7 @@ class HTMLFormFieldCloner extends HTMLFormField { if ( !array_key_exists( $fieldname, $value ) ) { continue; } - if ( $field->isHidden( $alldata ) ) { + if ( $field->isDisabled( $alldata ) ) { continue; } $ok = $field->validate( $value[$fieldname], $alldata ); diff --git a/includes/htmlform/fields/HTMLRestrictionsField.php b/includes/htmlform/fields/HTMLRestrictionsField.php index 7ba698190346..ffdc72bbdace 100644 --- a/includes/htmlform/fields/HTMLRestrictionsField.php +++ b/includes/htmlform/fields/HTMLRestrictionsField.php @@ -73,7 +73,7 @@ class HTMLRestrictionsField extends HTMLTextAreaField { * false to fail validation without displaying an error. */ public function validate( $value, $alldata ) { - if ( $this->isHidden( $alldata ) ) { + if ( $this->isDisabled( $alldata ) ) { return true; } |