diff options
| author | Daimona Eaytoy <daimona.wiki@gmail.com> | 2019-12-07 19:32:45 +0100 |
|---|---|---|
| committer | Daimona Eaytoy <daimona.wiki@gmail.com> | 2019-12-07 20:16:19 +0000 |
| commit | 598c4d7fcb68ab2b3ef8d895ef97224fe14d4832 (patch) | |
| tree | bd7e7770cde36b384e3e1b74d37cf8bb808a6397 /includes/htmlform | |
| parent | 3077097b77c19046918a9cd27f326eccbe49841f (diff) | |
| download | mediawikicore-598c4d7fcb68ab2b3ef8d895ef97224fe14d4832.tar.gz mediawikicore-598c4d7fcb68ab2b3ef8d895ef97224fe14d4832.zip | |
build: Upgrade phan to 0.9.0
Scalar casts are still allowed (for now), because there's a huge amount
of false positives. Ditto for invalid array offsets.
Thoughts about the rest: luckily, many false positives with array offsets
have gone. Moreover, since *Internal issues are suppressed in the base
config, we can remove inline suppressions.
Unfortunately, there are a couple of new issues about array additions
with only false positives, because apparently they don't take
branches into account.
Change-Id: I5a3913c6e762f77bfdae55051a395fae95d1f841
Diffstat (limited to 'includes/htmlform')
| -rw-r--r-- | includes/htmlform/HTMLFormField.php | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/includes/htmlform/HTMLFormField.php b/includes/htmlform/HTMLFormField.php index e4c6b30fc1c5..1d25f82d7144 100644 --- a/includes/htmlform/HTMLFormField.php +++ b/includes/htmlform/HTMLFormField.php @@ -550,6 +550,7 @@ abstract class HTMLFormField { } else { $field = Html::rawElement( 'div', + // @phan-suppress-next-line PhanUselessBinaryAddRight [ 'class' => $outerDivClass ] + $cellAttributes, $inputHtml . "\n$errors" ); |