DumpStringOutput: Rename getOutput() to __toString()

Though getOutput() is what first came to mind, I do not particularly
like the name, partly because it is used in many, many places as a
method that returns an OutputPage object.

* Renamed the method to __toString(). This is appropriate because
  each instance, at any given time, corresponds to a single string
  value (and exceptions cannot occur during this conversion).
* Removed unnecessary variables from ApiQuery and ExportTest. In
  these and most other cases, it should no longer be necessary to
  call getOutput() explicitly.

Change-Id: Icf202743d1f332f8981338f42eb6e3e5a04abdf1

1 files changed, 1 insertions, 1 deletions

diff --git a/includes/export/DumpStringOutput.php b/includes/export/DumpStringOutput.php
index 5168225179b1..837a62d62842 100644
--- a/includes/export/DumpStringOutput.php
+++ b/includes/export/DumpStringOutput.php
@@ -39,7 +39,7 @@ class DumpStringOutput extends DumpOutput {
 	 *
 	 * @return string
 	 */
-	public function getOutput() {
+	public function __toString() {
 		return $this->output;
 	}
 }