diff options
author | Tim Starling <tstarling@wikimedia.org> | 2023-03-24 12:14:02 +1100 |
---|---|---|
committer | Krinkle <krinkle@fastmail.com> | 2023-03-25 00:19:58 +0000 |
commit | 580ec48e5b322e505297f3eed0ebccbd269c2166 (patch) | |
tree | 53d9c47fe2a73c643c5d0d3c25ac3ee23f6eb3fa /includes/exception/FatalError.php | |
parent | d36ea70309c7cd264d3e3244738cce55d0a82e5b (diff) | |
download | mediawikicore-580ec48e5b322e505297f3eed0ebccbd269c2166.tar.gz mediawikicore-580ec48e5b322e505297f3eed0ebccbd269c2166.zip |
Fix more PHPStorm inspections (#2)
* Illegal string offset and invalid argument supplied to foreach, due to incorrect type information
* Array internal pointer reset is unnecessary
* $hookData unused since MW 1.35 due to incomplete revert
* array_push() with single element
* Unnecessary sprintf()
* for loop can be replaced with str_repeat()
* preg_replace() can be replaced with rtrim()
* array_values() call is redundant
* Unnecessary cast to string
* Unnecessary ternary. Often the result relies on short-circuit evaluation, but I find it more readable nonetheless.
Change-Id: I4c45bdb59b51b243fa96286bec8b58deb097d707
Diffstat (limited to 'includes/exception/FatalError.php')
0 files changed, 0 insertions, 0 deletions