diff options
author | Dreamy Jazz <wpgbrown@wikimedia.org> | 2024-12-05 16:47:38 +0000 |
---|---|---|
committer | Dreamy Jazz <wpgbrown@wikimedia.org> | 2024-12-05 20:13:56 +0000 |
commit | 92f00eea802edb827bb08c303d8875767fa13793 (patch) | |
tree | 858d54597dce9528e2efbbfe23341ca022c82714 /includes/diff/TextDiffer | |
parent | 7943b23bbb646d055adf49e9c150405a9dda9717 (diff) | |
download | mediawikicore-92f00eea802edb827bb08c303d8875767fa13793.tar.gz mediawikicore-92f00eea802edb827bb08c303d8875767fa13793.zip |
Silence inserts to the job table in JobQueueDB
Why:
* The JobQueueDB class is the default method used to queue jobs
in MediaWiki and uses the job table to store queued jobs.
* To insert a job into the queue the class needs to perform writes
to the job table, which is done when a transaction is about to
commit or there is no transaction active.
* Therefore, when a job is inserted to the queue and the job
queue uses the JobQueueDB class, it causes a write either
immediately or soon after the call.
* This means that on GET requests, the write violates the
TransactionProfiler expectations.
* There is nothing that we can do here to avoid the writes on
GET requests, because some code needs to ensure the job is
inserted before sending a response. Therefore, we should
silence the warnings regarding performing writes.
What:
* Wrap calls to get a primary DB and inserting to the primary DB
in a scope which silences the TransactionProfiler warnings
related to using a primary DB connection.
* Create tests for JobQueueDB so that the code being added is
covered by tests.
Bug: T379766
Change-Id: Ibd894ab0b99398429f3d8e9849fc0608f774e6cf
Diffstat (limited to 'includes/diff/TextDiffer')
0 files changed, 0 insertions, 0 deletions