diff options
| author | Aaron Schulz <aschulz@wikimedia.org> | 2019-04-02 01:25:48 -0700 |
|---|---|---|
| committer | Aaron Schulz <aschulz@wikimedia.org> | 2019-07-11 06:06:02 +0000 |
| commit | f588586e16c9c8043d6db1a262a00db4c12dc9a1 (patch) | |
| tree | 3e980a4626364368e20308d01555f2ab85bf88e3 /includes/deferred | |
| parent | 897e86ce9619d57924b506443cc1e32b46d1a394 (diff) | |
| download | mediawikicore-f588586e16c9c8043d6db1a262a00db4c12dc9a1.tar.gz mediawikicore-f588586e16c9c8043d6db1a262a00db4c12dc9a1.zip | |
Various fixes and simplifications to RefreshLinksJob::runTitle()
* Remove logic for saving slow-to-render parser output. This has
not worked ever since DerivedPageDataUpdater was introduced.
* Make the logic to use cached output actually work. This was
also broken since DerivedPageDataUpdater was added. In order
to pass the output, add a known-revision-output parameter
to both WikiPage::doSecondaryUpdates() and
DerivedPageDataUpdater::prepareUpdate().
* Also factored out some helper methods from runForTitle() in
RefreshLinksJob to make it more readable and avoid the need
for multiple transaction round commit calls. This makes the
case of multiple-title jobs less likely to break again.
* Make use of RefreshLinksJob::runForTitle() return value.
* Add unit tests for multiple-title job case.
Change-Id: I0cd13c424a87653b5a7253c42cd48fe43befd692
Diffstat (limited to 'includes/deferred')
| -rw-r--r-- | includes/deferred/LinksUpdate.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/deferred/LinksUpdate.php b/includes/deferred/LinksUpdate.php index 266d7687d060..5b68ff86ed82 100644 --- a/includes/deferred/LinksUpdate.php +++ b/includes/deferred/LinksUpdate.php @@ -203,7 +203,7 @@ class LinksUpdate extends DataUpdate implements EnqueueableDataUpdate { } /** - * Acquire a lock for performing link table updates for a page on a DB + * Acquire a session-level lock for performing link table updates for a page on a DB * * @param IDatabase $dbw * @param int $pageId |