diff options
| author | Umherirrender <umherirrender_de.wp@web.de> | 2020-06-15 12:46:22 +0200 |
|---|---|---|
| committer | Umherirrender <umherirrender_de.wp@web.de> | 2020-07-01 20:13:07 +0000 |
| commit | bc5cb7ae644bb8788499961dc6b009cb6f8b3a5e (patch) | |
| tree | 38354ca5f5a69c81616cdb27695a165c2c19ec9c /includes/cache/localisation/LocalisationCache.php | |
| parent | 7ba77c21c8c2cd4c0601d6c55fc3e6a18c5d75a4 (diff) | |
| download | mediawikicore-bc5cb7ae644bb8788499961dc6b009cb6f8b3a5e.tar.gz mediawikicore-bc5cb7ae644bb8788499961dc6b009cb6f8b3a5e.zip | |
phan: Enable redundant_condition_detection
Remove duplicate casts
Suppress false positives
Bug: T248438
Change-Id: I2f89664a4bcd3b39b15e7cf850adda2f0c90ae6f
Diffstat (limited to 'includes/cache/localisation/LocalisationCache.php')
| -rw-r--r-- | includes/cache/localisation/LocalisationCache.php | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/includes/cache/localisation/LocalisationCache.php b/includes/cache/localisation/LocalisationCache.php index 214cf7aab387..13f59cdecfa1 100644 --- a/includes/cache/localisation/LocalisationCache.php +++ b/includes/cache/localisation/LocalisationCache.php @@ -565,6 +565,7 @@ class LocalisationCache { } } } elseif ( $_fileType == 'aliases' ) { + // @phan-suppress-next-line PhanImpossibleCondition May be set in included file if ( isset( $aliases ) ) { $data['aliases'] = $aliases; } @@ -867,6 +868,7 @@ class LocalisationCache { } # Fill in the fallback if it's not there already + // @phan-suppress-next-line PhanSuspiciousValueComparison if ( ( $coreData['fallback'] === null || $coreData['fallback'] === false ) && $code === 'en' ) { $coreData['fallback'] = false; $coreData['originalFallbackSequence'] = $coreData['fallbackSequence'] = []; @@ -976,6 +978,7 @@ class LocalisationCache { continue; } + // @phan-suppress-next-line PhanTypeArraySuspiciousNullable if ( $allData[$key] === null || $this->isMergeableKey( $key ) ) { $this->mergeItem( $key, $allData[$key], $csData[$key] ); } |