diff options
author | Kosta Harlan <kharlan@wikimedia.org> | 2024-03-04 20:58:48 +0100 |
---|---|---|
committer | Kosta Harlan <kharlan@wikimedia.org> | 2024-04-29 10:55:20 +0200 |
commit | 30287f6be67d8912fe9c4f6cc57798c586b6ef1e (patch) | |
tree | aa05ce706e3206fbc14f32a6bd67aafebd56d149 /includes/api | |
parent | 1a7e43d92338003b8feb757bdfe59881d0a0eae2 (diff) | |
download | mediawikicore-30287f6be67d8912fe9c4f6cc57798c586b6ef1e.tar.gz mediawikicore-30287f6be67d8912fe9c4f6cc57798c586b6ef1e.zip |
Temporary accounts: Create user on edit save attempts
Why:
- Certain hooks and constraints that deny edits (SpamBlacklist,
AbuseFilter) generate manual log entries; these logs need to
reference an actor. The actor should be the same across multiple
failed attempts to save an edit.
- In order to hide the IP address associated with the request,
we can create a temporary account for every edit attempt, to
ensure that we associate the request with the log entry.
What:
- Create the temporary account at the beginning of
`EditPage::internalAttemptSave`. This is a change from the previous
temporary account creation paradigm, which created an account for a
successful edit attempt.
- Remove the pageUpdater->isChange check, as we don't have a pageUpdater
object at time of temp account creation.
- Temporary accounts are also created for no-op changes (pressing
"Publish" with unchanged wikitext editor contents)
- Note that temporary accounts are *not* created when permission related
errors are present in the edit attempt (e.g. a user attempts to edit
from a blocked IP address)
Bug: T359405
Change-Id: Ib6765f828681e70d798363338910a54c7de4ed67
Diffstat (limited to 'includes/api')
0 files changed, 0 insertions, 0 deletions