Add pure unit tests for ApiUnblock

Bug: T248686
Change-Id: I4de6a01014288973b69c53d236dbf1416dcf66fa

1 files changed, 11 insertions, 1 deletions

diff --git a/includes/api/ApiUnblock.php b/includes/api/ApiUnblock.php
index 97a7eabbae2b..33972e615a64 100644
--- a/includes/api/ApiUnblock.php
+++ b/includes/api/ApiUnblock.php
@@ -60,6 +60,16 @@ class ApiUnblock extends ApiBase {
 	}
 
 	/**
+	 * Exists so that the static call to UserCache::singleton can be overriden in tests
+	 *
+	 * @internal
+	 * @return UserCache
+	 */
+	protected function getUserCache() {
+		return UserCache::singleton();
+	}
+
+	/**
 	 * Unblocks the specified user or provides the reason the unblock failed.
 	 */
 	public function execute() {
@@ -73,7 +83,7 @@ class ApiUnblock extends ApiBase {
 		}
 
 		if ( $params['userid'] !== null ) {
-			$username = User::whoIs( $params['userid'] );
+			$username = $this->getUserCache()->getProp( $params['userid'], 'name' );
 
 			if ( $username === false ) {
 				$this->dieWithError( [ 'apierror-nosuchuserid', $params['userid'] ], 'nosuchuserid' );