api: Hard-deprecate ApiPageSet::get*Titles

The following functions are now hard-deprected:
- ApiPageSet::getTitles
- ApiPageSet::getGoodTitles
- ApiPageSet::getMissingTitles
- ApiPageSet::getGoodAndMissingTitles
- ApiPageSet::getRedirectTitles
- ApiPageSet::getSpecialTitles

Bug: T339384
Depends-On: Ie117ac8417e7f62ef3f199312a7f57df205900b2
Change-Id: I9533f89bbd370bcec43ca37200b2fedd0610183f

1 files changed, 12 insertions, 6 deletions

diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index d4347ce47d91..c7b998d56c70 100644
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -451,10 +451,11 @@ class ApiPageSet extends ApiBase {
 	 * Does not include special pages, interwiki links, and invalid titles.
 	 * If redirects are resolved, both the redirect and the target will be included here.
 	 *
-	 * @deprecated since 1.37, use getPages() instead.
+	 * @deprecated since 1.37, use getPages() instead, hard-deprecated since 1.43.
 	 * @return Title[]
 	 */
 	public function getTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mTitles;
 	}
 
@@ -489,10 +490,11 @@ class ApiPageSet extends ApiBase {
 	/**
 	 * Title objects that were found in the database, including redirects.
 	 * If redirects are resolved, this will include existing redirect targets.
-	 * @deprecated since 1.37, use getGoodPages() instead.
+	 * @deprecated since 1.37, use getGoodPages() instead, hard-deprecated since 1.43.
 	 * @return array<int,Title> Array page_id (int) => Title (obj)
 	 */
 	public function getGoodTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mGoodTitles;
 	}
 
@@ -527,10 +529,11 @@ class ApiPageSet extends ApiBase {
 	 * Title objects that were NOT found in the database.
 	 * The array's index will be negative for each item.
 	 * If redirects are resolved, this will include missing redirect targets.
-	 * @deprecated since 1.37, use getMissingPages instead.
+	 * @deprecated since 1.37, use getMissingPages instead, hard-deprecated since 1.43.
 	 * @return array<int,Title>
 	 */
 	public function getMissingTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mMissingTitles;
 	}
 
@@ -555,10 +558,11 @@ class ApiPageSet extends ApiBase {
 
 	/**
 	 * Title objects for good and missing titles.
-	 * @deprecated since 1.37, use getGoodAndMissingPages() instead.
+	 * @deprecated since 1.37, use getGoodAndMissingPages() instead, hard-deprecated since 1.43.
 	 * @return Title[]
 	 */
 	public function getGoodAndMissingTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mGoodTitles + $this->mMissingTitles;
 	}
 
@@ -591,10 +595,11 @@ class ApiPageSet extends ApiBase {
 	/**
 	 * Get a list of redirect resolutions - maps a title to its redirect
 	 * target.
-	 * @deprecated since 1.37, use getRedirectTargets instead.
+	 * @deprecated since 1.37, use getRedirectTargets instead, hard-deprecated since 1.43.
 	 * @return array<string,Title>
 	 */
 	public function getRedirectTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mRedirectTitles;
 	}
 
@@ -862,10 +867,11 @@ class ApiPageSet extends ApiBase {
 
 	/**
 	 * Get the list of titles with negative namespace
-	 * @deprecated since 1.37, use getSpecialPages() instead.
+	 * @deprecated since 1.37, use getSpecialPages() instead, hard-deprecated since 1.43.
 	 * @return Title[]
 	 */
 	public function getSpecialTitles() {
+		wfDeprecated( __METHOD__, '1.37' );
 		return $this->mSpecialTitles;
 	}