Rename Skin::getUsableSkins() to Skin::getAllowedSkins()

Follow-up to change 65426 (commit a3c7a8b8f)

Also, rewrite the documentation for this function call in Preferences.php
To remove the "(skins is all skin names from Language.php)"
which I couldn't make sense of.

Change-Id: I0b0fdfb5615c22aa876882c3ca344ebb1f10c4bd

1 files changed, 11 insertions, 2 deletions

diff --git a/includes/Skin.php b/includes/Skin.php
index 15b85453b760..f117e79c74aa 100644
--- a/includes/Skin.php
+++ b/includes/Skin.php
@@ -91,9 +91,9 @@ abstract class Skin extends ContextSource {
 	 * Fetch the list of user-selectable skins in regards to $wgSkipSkins.
 	 * Useful for Special:Preferences and other places where you
 	 * only want to show skins users _can_ use.
-	 * @return array of strings
+	 * @return string[]
 	 */
-	public static function getUsableSkins() {
+	public static function getAllowedSkins() {
 		global $wgSkipSkins;
 
 		$allowedSkins = self::getSkinNames();
@@ -106,6 +106,15 @@ abstract class Skin extends ContextSource {
 	}
 
 	/**
+	 * @deprecated since 1.22, use getAllowedSkins
+	 * @return string[]
+	 */
+	public static function getUsableSkins() {
+		wfDeprecated( __METHOD__, '1.22' );
+		return self::getAllowedSkins();
+	}
+
+	/**
 	 * Normalize a skin preference value to a form that can be loaded.
 	 * If a skin can't be found, it will fall back to the configured
 	 * default (or the old 'Classic' skin if that's broken).