diff options
author | MatmaRex <matma.rex@gmail.com> | 2013-03-06 21:10:15 +0100 |
---|---|---|
committer | Gerrit Code Review <gerrit@wikimedia.org> | 2013-04-29 00:00:09 +0000 |
commit | 7833589c5d576648b4db78bc69963bf8d516242d (patch) | |
tree | a69c625262712dede8c20cdaeb80e4edea8112bb /includes/Skin.php | |
parent | 32ac1518037adc66f78432108a306a4627d79be5 (diff) | |
download | mediawikicore-7833589c5d576648b4db78bc69963bf8d516242d.tar.gz mediawikicore-7833589c5d576648b4db78bc69963bf8d516242d.zip |
(bug 41729) Move section edit links to after the headings
This requires minor changes in various parts of MediaWiki, and
being extra careful about cached rendered pages' HTML.
Fun fact: editsection links are not made in Parser. They're made in
Linker, in Skin *and* in ParserOutput.
Client-side code and screen-scrapers will have to be adjusted to
handle both cases (old HTML will still be visible on cached page
renders until they are purged); extensions using the DoEditSectionLink
or EditSectionLink hooks might need adjustments as well.
* Linker: Change the HTML of pages to move the link itself from the
beginning of the heading (before <span class="mw-headline">) to the end
of the heading (after the span).
* Skin: Change the class from .editsection to .mw-editsection; we use this
opportunity to clean up old cruft, and this makes it much easier to
handle cached renders (by just detecting the old class).
* ParserOutput: Implement a horrible hack to support cached parser
outputs with the old order of items.
* Ensure everything that should support both classes supports both
classes (this includes print stylesheets and some scripts).
* Implement styles for the new look for all the skins (did this in
shared.css; the styles are non-intrusive and can be overridden
easily, and all of the skins were using the same look before).
Change-Id: I6a6c12a90de3604012420b20c1f520e0ece170ab
Diffstat (limited to 'includes/Skin.php')
-rw-r--r-- | includes/Skin.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/Skin.php b/includes/Skin.php index 24561d81df27..cc957c47d407 100644 --- a/includes/Skin.php +++ b/includes/Skin.php @@ -1533,14 +1533,14 @@ abstract class Skin extends ContextSource { # DoEditSectionLink: it can't change the brackets or the span.) $result = wfMessage( 'editsection-brackets' )->rawParams( $result ) ->inLanguage( $lang )->escaped(); - return "<span class=\"editsection\">$result</span>"; + return "<span class=\"mw-editsection\">$result</span>"; } # Add the brackets and the span, and *then* run the nice new hook, with # clean and non-redundant arguments. $result = wfMessage( 'editsection-brackets' )->rawParams( $link ) ->inLanguage( $lang )->escaped(); - $result = "<span class=\"editsection\">$result</span>"; + $result = "<span class=\"mw-editsection\">$result</span>"; wfRunHooks( 'DoEditSectionLink', array( $this, $nt, $section, $tooltip, &$result, $lang ) ); return $result; |