The war on redundant ampersand usage!

* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.

1 files changed, 2 insertions, 2 deletions

diff --git a/includes/SearchMySQL4.php b/includes/SearchMySQL4.php
index 9ba5860a659d..dbd88ecac580 100644
--- a/includes/SearchMySQL4.php
+++ b/includes/SearchMySQL4.php
@@ -29,8 +29,8 @@ class SearchMySQL4 extends SearchMySQL {
 	var $strictMatching = true;
 
 	/** @todo document */
-	function SearchMySQL4( &$db ) {
-		$this->db =& $db;
+	function SearchMySQL4( $db ) {
+		$this->db = $db;
 	}
 
 	/** @todo document */