diff options
| author | Petr Pchelko <ppchelko@wikimedia.org> | 2020-03-30 21:35:13 -0700 |
|---|---|---|
| committer | Petr Pchelko <ppchelko@wikimedia.org> | 2020-03-30 21:35:13 -0700 |
| commit | 977db777eec4d57bd4806c86190d0ddeeb016041 (patch) | |
| tree | b0dcc2079e2b6949d1061e4e7153838d3f87db7a /includes/Revision | |
| parent | d5142e021adee817c5cd78b66c4440746c9098fb (diff) | |
| download | mediawikicore-977db777eec4d57bd4806c86190d0ddeeb016041.tar.gz mediawikicore-977db777eec4d57bd4806c86190d0ddeeb016041.zip | |
Make RevisionFactory extend IDBAccessObject
RevisionFactory interface expects IDBAccessObject
query flags in all it's methods. It's a good practice
to references the flags by the interface they're being
used at, e.g. RevisionStore::READ_NORMAL for RevisionStore
etc. In order to do so, bring the flags into RevisionFactory
as well by extending IDBAccessObject
Change-Id: Ib74edf3f57472c588a1e41e9cb0899a50bb0eb8e
Diffstat (limited to 'includes/Revision')
| -rw-r--r-- | includes/Revision/RevisionFactory.php | 17 |
1 files changed, 13 insertions, 4 deletions
diff --git a/includes/Revision/RevisionFactory.php b/includes/Revision/RevisionFactory.php index 261e99640e8d..d612754e9317 100644 --- a/includes/Revision/RevisionFactory.php +++ b/includes/Revision/RevisionFactory.php @@ -22,6 +22,7 @@ namespace MediaWiki\Revision; +use IDBAccessObject; use MWException; use Title; @@ -34,7 +35,7 @@ use Title; * @note This was written to act as a drop-in replacement for the corresponding * static methods in Revision. */ -interface RevisionFactory { +interface RevisionFactory extends IDBAccessObject { /** * Constructs a new RevisionRecord based on the given associative array following the MW1.29 @@ -51,7 +52,11 @@ interface RevisionFactory { * @return MutableRevisionRecord * @throws MWException */ - public function newMutableRevisionFromArray( array $fields, $queryFlags = 0, Title $title = null ); + public function newMutableRevisionFromArray( + array $fields, + $queryFlags = self::READ_NORMAL, + Title $title = null + ); /** * Constructs a RevisionRecord given a database row and content slots. @@ -68,7 +73,11 @@ interface RevisionFactory { * * @return RevisionRecord */ - public function newRevisionFromRow( $row, $queryFlags = 0, Title $title = null ); + public function newRevisionFromRow( + $row, + $queryFlags = self::READ_NORMAL, + Title $title = null + ); /** * Make a fake revision object from an archive table row. This is queried @@ -89,7 +98,7 @@ interface RevisionFactory { */ public function newRevisionFromArchiveRow( $row, - $queryFlags = 0, + $queryFlags = self::READ_NORMAL, Title $title = null, array $overrides = [] ); |