ResourceLoader: Silence new encodeJson warning for $states array

Follows-up I89832142b55ec0f for T329330. encodeJson() is almost always
called with data that a core component or extension was responsible
for processing or generating. There is one exception that I know of,
namely within ResourceLoader itself, where we report back the name of
a load.php?modules parameter value if it doesn't exist or is invalid.

In that case, silence the newly added warning from encodeJson() since
the audience for that error is not the developers working on the code,
but the user making a badly formed URL. And the warning was coming
from the exact code formulating that same error message.

Bug: T331641
Change-Id: Idcccb979c89ef837546892ab786d803d429ecda5

1 files changed, 5 insertions, 1 deletions

diff --git a/includes/ResourceLoader/ResourceLoader.php b/includes/ResourceLoader/ResourceLoader.php
index 9ae1756ca9ee..ad46ddd35c86 100644
--- a/includes/ResourceLoader/ResourceLoader.php
+++ b/includes/ResourceLoader/ResourceLoader.php
@@ -1216,7 +1216,11 @@ MESSAGE;
 			}
 		} elseif ( $states ) {
 			$this->errors[] = 'Problematic modules: '
-				. $context->encodeJson( $states );
+				// Don't issue a server-side warning for client errors. (T331641)
+				// Modules with invalid encoded names can't be registered, but can be requested
+				// by forming a bad URL.
+				// phpcs:ignore Generic.PHP.NoSilencedErrors.Discouraged
+				. @$context->encodeJson( $states );
 		}
 
 		return $out;