diff options
| author | Kosta Harlan <kharlan@wikimedia.org> | 2023-02-01 11:43:40 +0100 |
|---|---|---|
| committer | Jdlrobson <jrobson@wikimedia.org> | 2023-02-01 22:50:01 +0000 |
| commit | b0a13b0595bffe29eb738201020af99e9141a068 (patch) | |
| tree | 244c85df71ca510aab21200fe860a2b20d84999f /includes/ResourceLoader/Module.php | |
| parent | 5974a8839fd78619e4d3a86b2a45ba03eb2c3caf (diff) | |
| download | mediawikicore-b0a13b0595bffe29eb738201020af99e9141a068.tar.gz mediawikicore-b0a13b0595bffe29eb738201020af99e9141a068.zip | |
Adjust default targets in RL/Module
In Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb, we changed the default
targets to desktop/mobile. This broke CI for PageTriage, which has a RL
module that extends ResourceLoader\Module, and which sets the default
targets for "desktop" only.
I am not sure if leaving ResourceLoader\Module as "desktop" only was a
deliberate choice or an oversight, but it seems to be more consistent to
have it defined as desktop/mobile. This will fix the issue for
PageTriage and other extensions that extend ResourceLoader\Module and
don't have any targets explicitly defined for their RL modules.
Follows-Up: Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb
Bug: T127268
Bug: T328497
Change-Id: I48ed19912610a74af66d620510c192c7ba87039a
Diffstat (limited to 'includes/ResourceLoader/Module.php')
| -rw-r--r-- | includes/ResourceLoader/Module.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/ResourceLoader/Module.php b/includes/ResourceLoader/Module.php index 9db42897f750..1933786e1705 100644 --- a/includes/ResourceLoader/Module.php +++ b/includes/ResourceLoader/Module.php @@ -63,7 +63,7 @@ abstract class Module implements LoggerAwareInterface { /** @var string|null Module name */ protected $name = null; /** @var string[] What client platforms the module targets (e.g. desktop, mobile) */ - protected $targets = [ 'desktop' ]; + protected $targets = [ 'desktop', 'mobile' ]; /** @var string[]|null Skin names */ protected $skins = null; |