RenameUserDerivedJob: Fix string interpolation

Why:

- Ic4120cbd9a4850dfe22d009daa171199fe7c5e39 added some code that uses
  the "${var}" string interpolation syntax, which is deprecated on PHP
  8.2 and newer.
- CI runs Phan on PHP 7.4, so it didn't catch this issue, but Phan on
  PHP >= 8.2 complains about it.

What:

- Fix the interpolation.

Bug: T314096
Change-Id: I2108ea8cfb2f890165ecba82e9023195b530f4bb

1 files changed, 2 insertions, 2 deletions

diff --git a/includes/RenameUser/Job/RenameUserDerivedJob.php b/includes/RenameUser/Job/RenameUserDerivedJob.php
index 243a39525bd2..240766c0708e 100644
--- a/includes/RenameUser/Job/RenameUserDerivedJob.php
+++ b/includes/RenameUser/Job/RenameUserDerivedJob.php
@@ -63,7 +63,7 @@ class RenameUserDerivedJob extends Job {
 		}
 		if ( $user->getName() !== $newName ) {
 			$logger->info(
-				"User to be renamed from ${oldName} to ${newName} does not have the expected name, skipping"
+				"User to be renamed from $oldName to $newName does not have the expected name, skipping"
 			);
 			return true;
 		}
@@ -83,7 +83,7 @@ class RenameUserDerivedJob extends Job {
 		$status = $rename->renameLocal();
 		if ( !$status->isGood() ) {
 			$logger->error(
-				"Cannot finish derived local user rename from ${oldName} to ${newName}: ${status}"
+				"Cannot finish derived local user rename from $oldName to $newName: $status"
 			);
 		}