diff options
| author | Erik Bernhardson <ebernhardson@wikimedia.org> | 2016-12-07 21:04:53 -0800 |
|---|---|---|
| committer | Erik Bernhardson <ebernhardson@wikimedia.org> | 2016-12-12 10:15:05 -0800 |
| commit | d67197fa116acc366419faedeeacd91158a98f8b (patch) | |
| tree | e61e97bf32cdb5f83e236b6e25948b8fb7fd6a19 /includes/ProtectionForm.php | |
| parent | f5b4bd19b2719e039a8b6a9ec35f88c1385abca0 (diff) | |
| download | mediawikicore-d67197fa116acc366419faedeeacd91158a98f8b.tar.gz mediawikicore-d67197fa116acc366419faedeeacd91158a98f8b.zip | |
Cleanup some incorrect return annotations
Most of these are simply changing annotations to reflect
reality. If a function can return false to indicate failure
the @return should indicate it.
Some are fixing preg_match calls, preg match returns 1, 0 or false,
but the functions all claim to return booleans.
This is far from all the incorrect return types in mediawiki, there
are around 250 detected by phan, but have to start somewhere.
Change-Id: I1bbdfee6190747bde460f8a7084212ccafe169ef
Diffstat (limited to 'includes/ProtectionForm.php')
| -rw-r--r-- | includes/ProtectionForm.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php index 451635e319dd..454ffcc978d2 100644 --- a/includes/ProtectionForm.php +++ b/includes/ProtectionForm.php @@ -148,7 +148,7 @@ class ProtectionForm { * * @param string $action * - * @return string 14-char timestamp or "infinity", or false if the input was invalid + * @return string|false 14-char timestamp or "infinity", or false if the input was invalid */ function getExpiry( $action ) { if ( $this->mExpirySelection[$action] == 'existing' ) { |