aboutsummaryrefslogtreecommitdiffstats
path: root/includes/Permissions
diff options
context:
space:
mode:
authorTim Starling <tstarling@wikimedia.org>2024-04-29 10:13:28 +1000
committerTim Starling <tstarling@wikimedia.org>2024-04-29 10:47:54 +1000
commit917f0a59960d437745b6f87b60f1e48f6cf7416b (patch)
treefa73dddae59ab8805b071c561aebd6aa9e6d223a /includes/Permissions
parent8c5c0edbfae8e6900a0a967cfcf669c015fea02b (diff)
downloadmediawikicore-917f0a59960d437745b6f87b60f1e48f6cf7416b.tar.gz
mediawikicore-917f0a59960d437745b6f87b60f1e48f6cf7416b.zip
Replace all instances of "per default" with "by default"
According to the dictionary, "per" (or more conventionally "as per") means "according to". Refer OED "per" sense II.3.a. For example: "No value was passed, so return null, as per default". In this sentence, we are not specifying the default, we are referring to the default. This correct usage of "per default" was used nowhere in MediaWiki core as far as I can see. Instead we have "per default" being used to mean "by default", that is, giving the value to use when no explicit value was specified. In OED, the phrase "by default" is blessed with its own section just for computing usage: "P.1.e. Computing. As an option or setting adopted automatically by a computer program whenever an alternative is not specified by the user or programmer. Cf. sense I.7a." There are highly similar pre-computing usages of the same phrase, whereas the phrase "per default" is not mentioned. As a matter of style, I think "per default" should not be used even when it is strictly correct, since the common incorrect usage makes it ambiguous and misleading. Change-Id: Ibcccc65ead864d082677b472b34ff32ff41c60ae
Diffstat (limited to 'includes/Permissions')
-rw-r--r--includes/Permissions/RateLimiter.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/Permissions/RateLimiter.php b/includes/Permissions/RateLimiter.php
index be247a6e7d1d..9018c9f298f3 100644
--- a/includes/Permissions/RateLimiter.php
+++ b/includes/Permissions/RateLimiter.php
@@ -198,7 +198,7 @@ class RateLimiter {
* @param RateLimitSubject $subject The subject of the rate limit, representing the
* client performing the action.
* @param string $action Action to enforce
- * @param int $incrBy Positive amount to increment counter by, 1 per default.
+ * @param int $incrBy Positive amount to increment counter by, 1 by default.
* Use 0 to check the limit without bumping the counter.
*
* @return bool True if a rate limit was exceeded.