diff options
| author | Brad Jorsch <bjorsch@wikimedia.org> | 2014-09-09 11:25:10 -0400 |
|---|---|---|
| committer | Tim Starling <tstarling@wikimedia.org> | 2014-12-31 10:24:05 +1100 |
| commit | 29951907f73e59b0fcfc43b3a2554ed77f2268d8 (patch) | |
| tree | c245ad8bf2ba7df0531b0fb10a484c3eda165292 /RELEASE-NOTES-1.25 | |
| parent | 64ade26dea51bbeb769d52cad9aa014d8b11604f (diff) | |
| download | mediawikicore-29951907f73e59b0fcfc43b3a2554ed77f2268d8.tar.gz mediawikicore-29951907f73e59b0fcfc43b3a2554ed77f2268d8.zip | |
Format multiple autocomments in edit summaries
Before r39373, all autocomments in an edit summary were formatted. In
fixing a bug with page titles containing "/*" this was accidentally
broken.
To use a single preg_replace_callback call to replace multiple
autocomments, we need to make sure that the match of one autocomment
doesn't overlap the match of another, which means we can't have "(.*)"
before and after. But we do still need to detect whether there is
anything before or after. "(?=(.?))" and "(?<=(.?))" would do nicely,
except the latter isn't actually supported. "(?=(.))?" and "(?<=(.))?"
work too, but older versions of PCRE don't support that. They do,
however, support "(?:(?=(.)))?" and "(?:(?<=(.)))?", so that's what
we'll go with.
This change does change the values for $pre and $post passed to the
FormatAutocomments hook; extensions need to be updated to accept (and
not prepend/append) booleans for these parameters.
Bug: T18530
Bug: T70361
Change-Id: I36c3a9e548a4ef72f93974bb35f9add8c29e9287
Diffstat (limited to 'RELEASE-NOTES-1.25')
| -rw-r--r-- | RELEASE-NOTES-1.25 | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/RELEASE-NOTES-1.25 b/RELEASE-NOTES-1.25 index ce50eac9d728..4a6ee9475008 100644 --- a/RELEASE-NOTES-1.25 +++ b/RELEASE-NOTES-1.25 @@ -113,6 +113,8 @@ production. ** Title::moveTo() was deprecated. Use the MovePage class instead. ** Title::isValidMoveOperation() broken down into MovePage::isValidMove() and MovePage::checkPermissions(). +* (T18530) Multiple autocomments are now formatted in an edit summary. +* (T70361) Autocomments containing "/*" are parsed correctly. * The Special:WhatLinksHere page linked from 'Number of redirects to this page' on action=info about a file page does not list file links anymore. * (T78637) Search bar is not autofocused unless it is empty so that proper scrolling using arrow keys is possible. @@ -284,6 +286,8 @@ changes to languages because of Bugzilla reports. However, this difference is unlikely to arise in practice. * (T67278) RFC, PMID, and ISBN "magic links" must be surrounded by non-word characters on both sides. +* The FormatAutocomments hook will now receive $pre and $post as booleans, + rather than as strings that must be prepended or appended to $comment. * (T30950, T31025) RFC, PMID, and ISBN "magic links" can no longer contain newlines; but they can contain and other non-newline whitespace. |