diff options
author | Timo Tijhof <krinkle@fastmail.com> | 2025-04-03 16:41:30 -0700 |
---|---|---|
committer | Timo Tijhof <krinkle@fastmail.com> | 2025-04-03 16:51:40 -0700 |
commit | f860fe1b18883d4081f09e1c1a5378f5274cdf9e (patch) | |
tree | 410712af9c9e26c11f5d2abfbd1aa0a49fcc80d3 /COPYING | |
parent | 358c211deb1c1b39af23ed72ddafb83425657508 (diff) | |
download | mediawikicore-f860fe1b18883d4081f09e1c1a5378f5274cdf9e.tar.gz mediawikicore-f860fe1b18883d4081f09e1c1a5378f5274cdf9e.zip |
Stats: Fix "MediaWiki.PHPUnit.AssertEquals.Int" in UnitTestingHelperTest
Follows-up I1b9435dcdacd952b, which introduced this and silenced the
warning, but it appears this warning is spot-on:
> $ composer phpcs
> …
> assertEquals accepts many non-zero values, please use strict alternatives like
> assertSame (MediaWiki.PHPUnit.AssertEquals.Int)
We don't want to tolerate something like this:
```
var_dump(1 == true);
class Foo{}
var_dump(1 == new Foo());
var_dump(1 == (object)[]);
var_dump(1 == new stdClass);
var_dump(1 == '01.0');
var_dump(1 == '01.');
var_dump(1 == '01');
var_dump(1 == '1');
```
Bug: T368740
Change-Id: Ib3966b96f65d41b1d320ae043dcbea1a445a55f5
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions