diff options
| author | Umherirrender <umherirrender_de.wp@web.de> | 2024-09-07 21:37:50 +0200 |
|---|---|---|
| committer | Umherirrender <umherirrender_de.wp@web.de> | 2024-09-07 21:37:50 +0200 |
| commit | dac84bf820e17f7b08305fabad5c155798bd480c (patch) | |
| tree | 722ef7885a9cce492a085f58f848396e51a2994f | |
| parent | e659256efebe478fab1ce5d16b67faa2cccdf5d6 (diff) | |
| download | mediawikicore-dac84bf820e17f7b08305fabad5c155798bd480c.tar.gz mediawikicore-dac84bf820e17f7b08305fabad5c155798bd480c.zip | |
Add missing documentation to class properties in NameTableStoreFactory
Add doc-typehints to class properties found by the PropertyDocumentation
sniff to improve the documentation.
Once the sniff is enabled it avoids that new code is missing type
declarations. This is focused on documentation and does not change code.
This also avoid false positive from phan
Change-Id: I4b182fda29e9cb9719c26fd01a609de2453be56d
| -rw-r--r-- | includes/Storage/NameTableStoreFactory.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/includes/Storage/NameTableStoreFactory.php b/includes/Storage/NameTableStoreFactory.php index 4ba8fb958ed8..c51a299e2f73 100644 --- a/includes/Storage/NameTableStoreFactory.php +++ b/includes/Storage/NameTableStoreFactory.php @@ -26,7 +26,9 @@ use WANObjectCache; use Wikimedia\Rdbms\ILBFactory; class NameTableStoreFactory { + /** @var array[]|null */ private static $info; + /** @var NameTableStore[][] */ private $stores = []; /** @var ILBFactory */ @@ -110,9 +112,7 @@ class NameTableStoreFactory { $this->cache, $this->logger, $tableName, - // @phan-suppress-next-line PhanTypeMismatchArgumentNullable False positive $info['idField'], - // @phan-suppress-next-line PhanTypeMismatchArgumentNullable False positive $info['nameField'], $info['normalizationCallback'] ?? null, $wiki, |