diff options
author | Umherirrender <umherirrender_de.wp@web.de> | 2021-05-17 21:50:12 +0200 |
---|---|---|
committer | Umherirrender <umherirrender_de.wp@web.de> | 2021-05-17 23:00:40 +0200 |
commit | 8831b494c1c2d50ec5e030a7fb40ed396bea8089 (patch) | |
tree | a291fdfbf12848decfd823e49085f366930d1763 | |
parent | f10562720fbf8623a89e6aa3c34ffa01b0d9ee0e (diff) | |
download | mediawikicore-8831b494c1c2d50ec5e030a7fb40ed396bea8089.tar.gz mediawikicore-8831b494c1c2d50ec5e030a7fb40ed396bea8089.zip |
Use @deprecated annotation on hook interfaces, not functions
Use only one place to document the deprecation of hook
interfaces/functions
Bug: T282903
Change-Id: Ie7d2d7a50afe2897e5c2369f473a33ecaa821637
5 files changed, 5 insertions, 9 deletions
diff --git a/includes/Hook/EditPageBeforeEditToolbarHook.php b/includes/Hook/EditPageBeforeEditToolbarHook.php index 6e67bbdc1165..782f01891a43 100644 --- a/includes/Hook/EditPageBeforeEditToolbarHook.php +++ b/includes/Hook/EditPageBeforeEditToolbarHook.php @@ -6,6 +6,7 @@ namespace MediaWiki\Hook; * This is a hook handler interface, see docs/Hooks.md. * Use the hook name "EditPageBeforeEditToolbar" to register handlers implementing this interface. * + * @deprecated 1.36 Use one of the many other EditPage hooks instead * @ingroup Hooks */ interface EditPageBeforeEditToolbarHook { @@ -13,7 +14,6 @@ interface EditPageBeforeEditToolbarHook { * Use this hook to add an edit toolbar above the textarea in the edit form. * * @since 1.35 - * @deprecated 1.36 Use one of the many other EditPage hooks instead * * @param string &$toolbar Toolbar HTML, initially an empty `<div id="toolbar"></div>` * @return bool|void True or no return value to continue, or false to have diff --git a/includes/Hook/TitleArrayFromResultHook.php b/includes/Hook/TitleArrayFromResultHook.php index 067156caed1f..b4e36dc63eee 100644 --- a/includes/Hook/TitleArrayFromResultHook.php +++ b/includes/Hook/TitleArrayFromResultHook.php @@ -9,6 +9,7 @@ use Wikimedia\Rdbms\IResultWrapper; * This is a hook handler interface, see docs/Hooks.md. * Use the hook name "TitleArrayFromResult" to register handlers implementing this interface. * + * @deprecated since 1.36 * @ingroup Hooks */ interface TitleArrayFromResultHook { @@ -17,7 +18,6 @@ interface TitleArrayFromResultHook { * database result. * * @since 1.35 - * @deprecated since 1.36 * * @param TitleArray &$titleArray Set this to an object to override the default object returned * @param IResultWrapper $res Database result used to create the object diff --git a/includes/content/Hook/SecondaryDataUpdatesHook.php b/includes/content/Hook/SecondaryDataUpdatesHook.php index a150a89d6691..f81ac53e7543 100644 --- a/includes/content/Hook/SecondaryDataUpdatesHook.php +++ b/includes/content/Hook/SecondaryDataUpdatesHook.php @@ -19,9 +19,6 @@ interface SecondaryDataUpdatesHook { /** * Use this hook to modify the list of DataUpdates to perform when page content is modified. * - * @deprecated since 1.32 Use RevisionDataUpdates or override - * ContentHandler::getSecondaryDataUpdates instead. - * * @param Title $title Title of the page that is being edited * @param Content $oldContent Page content before the edit * @param bool $recursive Whether DataUpdates should trigger recursive updates diff --git a/includes/interwiki/Hook/InterwikiLoadPrefixHook.php b/includes/interwiki/Hook/InterwikiLoadPrefixHook.php index 3717e2294e30..296a6d96a14f 100644 --- a/includes/interwiki/Hook/InterwikiLoadPrefixHook.php +++ b/includes/interwiki/Hook/InterwikiLoadPrefixHook.php @@ -6,6 +6,8 @@ namespace MediaWiki\Interwiki\Hook; * This is a hook handler interface, see docs/Hooks.md. * Use the hook name "InterwikiLoadPrefix" to register handlers implementing this interface. * + * @deprecated Does not support enumerating all valid prefixes; for testing + * purposes (re)set $wgInterwikiCache instead. * @stable to implement * @ingroup Hooks */ @@ -14,8 +16,6 @@ interface InterwikiLoadPrefixHook { * This hook is called when resolving whether a given prefix is an interwiki or not. * * @since 1.35 - * @deprecated Does not support enumerating all valid prefixes; for testing - * purposes (re)set $wgInterwikiCache instead. * * @param string $prefix Interwiki prefix we are looking for * @param array &$iwData Output array describing the interwiki with keys iw_url, iw_local, diff --git a/includes/parser/Hook/BeforeParserFetchTemplateAndtitleHook.php b/includes/parser/Hook/BeforeParserFetchTemplateAndtitleHook.php index 3f7caa25682e..dbe2f4b74785 100644 --- a/includes/parser/Hook/BeforeParserFetchTemplateAndtitleHook.php +++ b/includes/parser/Hook/BeforeParserFetchTemplateAndtitleHook.php @@ -9,7 +9,7 @@ use Title; * This is a hook handler interface, see docs/Hooks.md. * Use the hook name "BeforeParserFetchTemplateAndtitle" to register handlers implementing this interface. * - * @deprecated since 1.36 + * @deprecated since 1.36; use BeforeParserFetchTemplateRevisionRecordHook * @ingroup Hooks */ interface BeforeParserFetchTemplateAndtitleHook { @@ -17,7 +17,6 @@ interface BeforeParserFetchTemplateAndtitleHook { * This hook is called before a template is fetched by Parser. * * @since 1.35 - * @deprecated since 1.36; use BeforeParserFetchTemplateRevisionRecordHook * * @param Parser $parser * @param Title $title Title of the template |