diff options
| author | jenkins-bot <jenkins-bot@gerrit.wikimedia.org> | 2024-05-04 19:31:33 +0000 |
|---|---|---|
| committer | Gerrit Code Review <gerrit@wikimedia.org> | 2024-05-04 19:31:33 +0000 |
| commit | 6c8c76f2a8a89e73fe2801756ebc89fba86ea33d (patch) | |
| tree | eeed19a5cb50a08dae9c51fcd1e27005ef5248df | |
| parent | cefae6eb1feaddd690afaf7ff4c6712812e368ff (diff) | |
| parent | e3e911aeca28edd276460b173641f1507a9eaadd (diff) | |
| download | mediawikicore-6c8c76f2a8a89e73fe2801756ebc89fba86ea33d.tar.gz mediawikicore-6c8c76f2a8a89e73fe2801756ebc89fba86ea33d.zip | |
Merge "Create account page: replace headings problematic for accessibilty"
| -rw-r--r-- | includes/specialpage/LoginSignupSpecialPage.php | 6 | ||||
| -rw-r--r-- | resources/src/mediawiki.special.userlogin.signup.styles/signup.less | 20 |
2 files changed, 12 insertions, 14 deletions
diff --git a/includes/specialpage/LoginSignupSpecialPage.php b/includes/specialpage/LoginSignupSpecialPage.php index c6829230dc21..7b5fede6a060 100644 --- a/includes/specialpage/LoginSignupSpecialPage.php +++ b/includes/specialpage/LoginSignupSpecialPage.php @@ -656,7 +656,7 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage { $headUnescaped = $this->msg( "createacct-benefit-head$benefitIdx" )->text(); $iconClass = $this->msg( "createacct-benefit-icon$benefitIdx" )->text(); $benefitList .= Html::rawElement( 'div', [ 'class' => "mw-number-text $iconClass" ], - Html::rawElement( 'h3', [], + Html::rawElement( 'span', [], $this->msg( "createacct-benefit-head$benefitIdx" )->escaped() ) . Html::rawElement( 'p', [], @@ -665,7 +665,9 @@ abstract class LoginSignupSpecialPage extends AuthManagerSpecialPage { ); } $benefitsContainer = Html::rawElement( 'div', [ 'class' => 'mw-createacct-benefits-container' ], - Html::rawElement( 'h2', [], $this->msg( 'createacct-benefit-heading' )->escaped() ) + Html::rawElement( 'div', [ 'class' => 'mw-createacct-benefits-heading' ], + $this->msg( 'createacct-benefit-heading' )->escaped() + ) . Html::rawElement( 'div', [ 'class' => 'mw-createacct-benefits-list' ], $benefitList ) ); } else { diff --git a/resources/src/mediawiki.special.userlogin.signup.styles/signup.less b/resources/src/mediawiki.special.userlogin.signup.styles/signup.less index 086425439c36..1f9ee8af7170 100644 --- a/resources/src/mediawiki.special.userlogin.signup.styles/signup.less +++ b/resources/src/mediawiki.special.userlogin.signup.styles/signup.less @@ -6,18 +6,14 @@ flex-wrap: wrap; column-gap: 100px; row-gap: 50px; - - /* Disable the underline that Vector puts on h2 headings, and bold them. */ - h2 { - border: 0; - font-weight: bold; - } } -.mw-createacct-benefits-container { - h2 { - margin-bottom: 30px; - } +.mw-createacct-benefits-heading { + font-family: @font-family-serif; + font-size: 1.5em; + font-weight: bold; + margin: 0.25em 0; + padding-top: 0.5em; } /* stylelint-disable-next-line selector-class-pattern */ @@ -40,9 +36,8 @@ /* * Special font for numbers in benefits, same as Vector's `@content-heading-font-family`. - * Needs to be more specific than Vector's `.mw-body-content h3`. */ -.mw-body-content .mw-number-text h3 { +.mw-body-content .mw-number-text span { color: @color-base; margin: 0; padding: 0; @@ -51,6 +46,7 @@ font-size: 2.2em; line-height: 1.2; text-align: center; + display: block; } /* Contains a “headlined” number and explanatory text, with space for an icon */ |