aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>2025-03-30 10:12:56 +0000
committerGerrit Code Review <gerrit@wikimedia.org>2025-03-30 10:12:56 +0000
commit52b83f2930dbd25ab85c5820ed0ae3f9967fee20 (patch)
tree9a47f8e5fee368b7464f6bcdae1d24bfa3fb9f2e
parent1e01994f4b515bbea5dd345f098a89b98fe10640 (diff)
parentb9c99fc622fd633d196467c773eef4ca32bea85f (diff)
downloadmediawikicore-52b83f2930dbd25ab85c5820ed0ae3f9967fee20.tar.gz
mediawikicore-52b83f2930dbd25ab85c5820ed0ae3f9967fee20.zip
Merge "Fix GREATEST usage in site_stats" into REL1_43
-rw-r--r--includes/deferred/SiteStatsUpdate.php11
1 files changed, 4 insertions, 7 deletions
diff --git a/includes/deferred/SiteStatsUpdate.php b/includes/deferred/SiteStatsUpdate.php
index 28e1fee4a2ac..1f67b787fc16 100644
--- a/includes/deferred/SiteStatsUpdate.php
+++ b/includes/deferred/SiteStatsUpdate.php
@@ -138,16 +138,13 @@ class SiteStatsUpdate implements DeferrableUpdate, MergeableUpdate {
$delta = (int)$deltaByType[$type];
$initValues[$field] = $delta;
if ( $delta > 0 ) {
- $set[$field] = new RawSQLValue( $dbw->buildGreatest(
- [ $field => $dbw->addIdentifierQuotes( $field ) . '+' . abs( $delta ) ],
- 0
- ) );
+ $set[$field] = new RawSQLValue( $dbw->addIdentifierQuotes( $field ) . '+' . abs( $delta ) );
} elseif ( $delta < 0 ) {
$hasNegativeDelta = true;
$set[$field] = new RawSQLValue( $dbw->buildGreatest(
- [ 'new' => $dbw->addIdentifierQuotes( $field ) . '-' . abs( $delta ) ],
- 0
- ) );
+ [ 'new' => $dbw->addIdentifierQuotes( $field ) ],
+ abs( $delta )
+ ) . '-' . abs( $delta ) );
}
}