aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDannyS712 <dannys712.wiki@gmail.com>2021-07-15 04:17:10 +0000
committerDannyS712 <dannys712.wiki@gmail.com>2021-07-15 04:19:07 +0000
commit2f802e82c80019669231114d7e9ffafc27f42f9c (patch)
tree4926febe05e09918f0877e30fb2be64e49c9ad29
parente455352a0499d13cb603bb9b1fcd74df3f57218b (diff)
downloadmediawikicore-2f802e82c80019669231114d7e9ffafc27f42f9c.tar.gz
mediawikicore-2f802e82c80019669231114d7e9ffafc27f42f9c.zip
Deprecate unused BotPassword methods
BotPassword::invalidateAllPasswordsForCentralId() and BotPassword::removeAllPasswordsForCentralId() are no longer used following introduction of BotPasswordStore. Bug: T265769 Change-Id: I77589032a8b771d1e111e8adbee3600f181fedbc
-rw-r--r--RELEASE-NOTES-1.372
-rw-r--r--includes/user/BotPassword.php8
2 files changed, 8 insertions, 2 deletions
diff --git a/RELEASE-NOTES-1.37 b/RELEASE-NOTES-1.37
index d561fc76dfe4..b83505a70468 100644
--- a/RELEASE-NOTES-1.37
+++ b/RELEASE-NOTES-1.37
@@ -493,6 +493,8 @@ because of Phabricator reports.
warnings.
* CentralIdLookup::factory and ::factoryNonLocal were deprecated, obtain an
instance from MediaWikiServices instead.
+* BotPassword::invalidateAllPasswordsForCentralId() was deprecated.
+* BotPassword::removeAllPasswordsForCentralId() was deprecated.
* The Title class members: $mTextform, $mUrlform, $mDbkeyform, $mNamespace,
$mInterwiki, and $mFragment have been deprecated to not be used directly.
Instead, their corresponding accessor methods should be used.
diff --git a/includes/user/BotPassword.php b/includes/user/BotPassword.php
index 46117a367fae..565155f04605 100644
--- a/includes/user/BotPassword.php
+++ b/includes/user/BotPassword.php
@@ -344,12 +344,14 @@ class BotPassword implements IDBAccessObject {
/**
* Invalidate all passwords for a user, by central ID
*
- * Currently unused entirely, to be hard deprecated
+ * @deprecated since 1.37
*
* @param int $centralId
* @return bool Whether any passwords were invalidated
*/
public static function invalidateAllPasswordsForCentralId( $centralId ) {
+ wfDeprecated( __METHOD__, '1.37' );
+
global $wgEnableBotPasswords;
if ( !$wgEnableBotPasswords ) {
@@ -380,12 +382,14 @@ class BotPassword implements IDBAccessObject {
/**
* Remove all passwords for a user, by central ID
*
- * Currently unused entirely, to be hard deprecated
+ * @deprecated since 1.37
*
* @param int $centralId
* @return bool Whether any passwords were removed
*/
public static function removeAllPasswordsForCentralId( $centralId ) {
+ wfDeprecated( __METHOD__, '1.37' );
+
global $wgEnableBotPasswords;
if ( !$wgEnableBotPasswords ) {