aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlangi Derick <alangiderick@gmail.com>2018-12-03 12:25:33 +0100
committerAlangi Derick <alangiderick@gmail.com>2018-12-03 12:28:48 +0100
commit0848d0e607d03e988b3dad8465611c75875c003d (patch)
treec49495398c3613b8a4bc660ccccb12e59cd6f139
parentf7ab788bf174c33e8477b745dee42cf5a0140a90 (diff)
downloadmediawikicore-0848d0e607d03e988b3dad8465611c75875c003d.tar.gz
mediawikicore-0848d0e607d03e988b3dad8465611c75875c003d.zip
export: Fix return value of write() function in DumpOutput.php
Per http://php.net/manual/en/function.print.php, print always returns 1 (integer value of one) but write() doesn't actually return this value to it's caller. So "@return bool" in this case doesn't make sense as one will think it's returning a bool type. `write()` only takes a string and prints it, and if we really want to return it's value (in this case), it will be "@return int" not data of type bool. Change-Id: I45b4a157cde2f768d77dda76d6ae0caa47e28f20
-rw-r--r--includes/export/DumpOutput.php1
1 files changed, 0 insertions, 1 deletions
diff --git a/includes/export/DumpOutput.php b/includes/export/DumpOutput.php
index edd73fcfc3e1..ab925b75fff0 100644
--- a/includes/export/DumpOutput.php
+++ b/includes/export/DumpOutput.php
@@ -76,7 +76,6 @@ class DumpOutput {
/**
* Override to write to a different stream type.
* @param string $string
- * @return bool
*/
function write( $string ) {
print $string;