diff options
| author | Kevin Israel <pleasestand@live.com> | 2022-12-03 04:19:24 -0500 |
|---|---|---|
| committer | Kevin Israel <pleasestand@live.com> | 2022-12-03 05:05:40 -0500 |
| commit | a70e8fa299d3386d3b125ba42777ca5ebe91a54c (patch) | |
| tree | dc6db02c60580b736efa9c7096b3dd5f8865644b /.phpcs.xml | |
| parent | 8418414ec050e630e49297e9fc6accb9d0b5768a (diff) | |
| download | mediawikicore-a70e8fa299d3386d3b125ba42777ca5ebe91a54c.tar.gz mediawikicore-a70e8fa299d3386d3b125ba42777ca5ebe91a54c.zip | |
phpcs: Remove comment regarding silence (at-sign) operator in tests
This comment was added in 355a6cd4c3045202 and quickly became outdated.
While it should still mostly be correct, it is no longer "policy" to use
the at-ease library. The "@" operator is now explicitly permitted where
necessary and is now recommended even outside tests (T253461). As such,
it no longer makes sense to keep this comment around.
Change-Id: I07aa84d46be8c7e5a1c8a3249d382cbbfef80267
Diffstat (limited to '.phpcs.xml')
| -rw-r--r-- | .phpcs.xml | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/.phpcs.xml b/.phpcs.xml index af99381a10fa..f4d029eaca22 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -118,26 +118,6 @@ <exclude-pattern>*/tests/phpunit/integration/includes/GlobalFunctions/*</exclude-pattern> </rule> <rule ref="Generic.PHP.NoSilencedErrors.Discouraged"> - <!-- - Our normal policy of using Wikimedia\AtEase does not always make sense tests. - - AtEase cannot be cleanly used in tests that also use expectException() as - the restoreWarnings() call would never be reached: - - $this->expectException( PasswordError::class ); - AtEase::suppressWarnings(); - $password->crypt( 'whatever' ); - AtEase::restoreWarnings(); - - The above will stop at crypt(), as expected, and leave AtEase in a dirty - state for unrelated tests. - - TODO: Stop using PHPUnit TestCase directly. Require with a structure test - or with a high-level check in our run() hook, that all test cases use either - MediaWikiUnitTestCase or MediaWikiIntegrationTestCase. Otherwise the check - in MediaWikiTestCaseTrait can still be bypassed and cause a random failures. - - --> <exclude-pattern>*/tests/*</exclude-pattern> </rule> <rule ref="Generic.Files.OneObjectStructurePerFile.MultipleFound"> |