aboutsummaryrefslogtreecommitdiffstats
path: root/.phan
diff options
context:
space:
mode:
authordaniel <dkinzler@wikimedia.org>2022-04-27 16:31:59 +0200
committerdaniel <dkinzler@wikimedia.org>2022-05-30 21:27:09 +0200
commit7f8e3c5360ad63db808f3c5b1065db244a94f0b4 (patch)
tree04daa412e483f06a4fbecbca0d1f0f5fbcb9a730 /.phan
parent278c3dd2300c9b458c9fc287a683fa4fbe736ec0 (diff)
downloadmediawikicore-7f8e3c5360ad63db808f3c5b1065db244a94f0b4.tar.gz
mediawikicore-7f8e3c5360ad63db808f3c5b1065db244a94f0b4.zip
Docs: remove references to DefaultSettings.php
Bug: T300129 Change-Id: I1e83a0dde6235bed91d28d7d43691c6a5d979f2f
Diffstat (limited to '.phan')
-rw-r--r--.phan/config.php7
1 files changed, 4 insertions, 3 deletions
diff --git a/.phan/config.php b/.phan/config.php
index 9d997d63cf99..931252774665 100644
--- a/.phan/config.php
+++ b/.phan/config.php
@@ -35,7 +35,6 @@ $cfg['file_list'] = array_merge(
// You can check the parser order with --dump-parsed-file-list
'includes/Defines.php',
// @todo This isn't working yet, see globals_type_map below
- // 'includes/DefaultSettings.php',
// 'includes/Setup.php',
]
);
@@ -104,8 +103,10 @@ $cfg['exclude_analysis_directory_list'] = [
$cfg['enable_class_alias_support'] = false;
$cfg['ignore_undeclared_variables_in_global_scope'] = true;
-// @todo It'd be great if we could just make phan read these from DefaultSettings, to avoid
-// duplicating the types.
+// @todo It'd be great if we could just make phan read these from config-schema.php, to avoid
+// duplicating the types. config-schema.php has JSON types though, not PHP types.
+// @todo As we are removing access to global variables from the code base,
+// remove them from here as well, so phan complains when something tries to use them.
$cfg['globals_type_map'] = array_merge( $cfg['globals_type_map'], [
'IP' => 'string',
'wgGalleryOptions' => 'array',