From 7f8e3c5360ad63db808f3c5b1065db244a94f0b4 Mon Sep 17 00:00:00 2001 From: daniel Date: Wed, 27 Apr 2022 16:31:59 +0200 Subject: Docs: remove references to DefaultSettings.php Bug: T300129 Change-Id: I1e83a0dde6235bed91d28d7d43691c6a5d979f2f --- .phan/config.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to '.phan') diff --git a/.phan/config.php b/.phan/config.php index 9d997d63cf99..931252774665 100644 --- a/.phan/config.php +++ b/.phan/config.php @@ -35,7 +35,6 @@ $cfg['file_list'] = array_merge( // You can check the parser order with --dump-parsed-file-list 'includes/Defines.php', // @todo This isn't working yet, see globals_type_map below - // 'includes/DefaultSettings.php', // 'includes/Setup.php', ] ); @@ -104,8 +103,10 @@ $cfg['exclude_analysis_directory_list'] = [ $cfg['enable_class_alias_support'] = false; $cfg['ignore_undeclared_variables_in_global_scope'] = true; -// @todo It'd be great if we could just make phan read these from DefaultSettings, to avoid -// duplicating the types. +// @todo It'd be great if we could just make phan read these from config-schema.php, to avoid +// duplicating the types. config-schema.php has JSON types though, not PHP types. +// @todo As we are removing access to global variables from the code base, +// remove them from here as well, so phan complains when something tries to use them. $cfg['globals_type_map'] = array_merge( $cfg['globals_type_map'], [ 'IP' => 'string', 'wgGalleryOptions' => 'array', -- cgit v1.2.3