diff options
author | Máté Szabó <mszabo@wikimedia.org> | 2025-02-12 13:41:37 +0100 |
---|---|---|
committer | Máté Szabó <mszabo@wikimedia.org> | 2025-02-12 13:41:37 +0100 |
commit | 97687df3f8e661cfdff3e07036a7882d02b72a03 (patch) | |
tree | 5e65e317fac57cebd0955838c615e112e18ccdf9 /.gitmessage | |
parent | d9c3d090530c4929e4fbf58de197e4d907f84658 (diff) | |
download | mediawikicore-97687df3f8e661cfdff3e07036a7882d02b72a03.tar.gz mediawikicore-97687df3f8e661cfdff3e07036a7882d02b72a03.zip |
rdbms: Don't forward DB connection handle to transaction callbacks
Why:
- When a transaction lifecycle callback such as
onTransactionPreCommitOrIdle() is invoked by rdbms, rdbms passes in
the DB connection handle the callback was scheduled on.
- However, the DB connection handle may have since been reset to a
different DB domain on the same physical cluster due to connection
reuse.
- We could implement bookkeeping to keep track of the expected DB domain
for each pending callback and ensure the passed-in DB handle matches
that before invoking the callback, but nobody seems to be making use
of the passed-in DB handle except for two call sites in core.
- As such, it seems more prudent to remove this functionality.
What:
- Stop passing the DB connection handle to rdbms transaction lifecycle
callbacks.
Bug: T386190
Change-Id: I9125bfb8b5e2cac4aab3525ffd229ea49beccc17
Diffstat (limited to '.gitmessage')
0 files changed, 0 insertions, 0 deletions