diff options
author | Tim Starling <tstarling@wikimedia.org> | 2024-03-04 16:27:34 +1100 |
---|---|---|
committer | Tim Starling <tstarling@wikimedia.org> | 2024-03-13 13:04:13 +1100 |
commit | 3f852f7ddc20d3d126b155cfcdc543af6a5181ab (patch) | |
tree | 1229b4a69b613b548392bfcfd4c1a6ec6ae974eb /.gitmessage | |
parent | 2d9190700d5187182b97eb5b9e691d824328ef86 (diff) | |
download | mediawikicore-3f852f7ddc20d3d126b155cfcdc543af6a5181ab.tar.gz mediawikicore-3f852f7ddc20d3d126b155cfcdc543af6a5181ab.zip |
Split web-specific code out of DatabaseInstaller
DatabaseInstaller had some LSP violations, such as calling undeclared
methods of the supplied Installer object, assuming that it was a
WebInstaller. It was also large.
So, split the web form parts of DatabaseInstaller into separate classes.
We have a class hierarchy for the connect forms, and a class hierarchy
for the settings forms, with a base class DatabaseForm mostly as a place
to put protected helper methods.
Also, have DatabaseInstaller::getConnection() return a special subclass
of Status, so that we can remove many Phan type overrides.
Change-Id: Ie84025f8f70b895fa6882848b9a21ba1750d60e2
Diffstat (limited to '.gitmessage')
0 files changed, 0 insertions, 0 deletions