{ "action": "synchronize", "number": 19612, "pull_request": { "url": "https://api.github.com/repos/servo/servo/pulls/19612", "id": 159474132, "html_url": "https://github.com/servo/servo/pull/19612", "diff_url": "https://github.com/servo/servo/pull/19612.diff", "patch_url": "https://github.com/servo/servo/pull/19612.patch", "issue_url": "https://api.github.com/repos/servo/servo/issues/19612", "number": 19612, "state": "open", "locked": false, "title": "deny warnings", "user": { "login": "tigercosmos", "id": 18013815, "avatar_url": "https://avatars0.githubusercontent.com/u/18013815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tigercosmos", "html_url": "https://github.com/tigercosmos", "followers_url": "https://api.github.com/users/tigercosmos/followers", "following_url": "https://api.github.com/users/tigercosmos/following{/other_user}", "gists_url": "https://api.github.com/users/tigercosmos/gists{/gist_id}", "starred_url": "https://api.github.com/users/tigercosmos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tigercosmos/subscriptions", "organizations_url": "https://api.github.com/users/tigercosmos/orgs", "repos_url": "https://api.github.com/users/tigercosmos/repos", "events_url": "https://api.github.com/users/tigercosmos/events{/privacy}", "received_events_url": "https://api.github.com/users/tigercosmos/received_events", "type": "User", "site_admin": false }, "body": "\r\ndeny warnings\r\nrelated to #19573\r\n\r\n---\r\n\r\n- [ ] `./mach build -d` does not report any errors\r\n- [ ] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #19572 (github issue number if applicable).\r\n\r\n\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n\r\n\r\n\n\n\n---\nThis change is [\"Reviewable\"/](https://reviewable.io/reviews/servo/servo/19612)\n\n", "created_at": "2017-12-20T17:24:41Z", "updated_at": "2017-12-21T13:34:10Z", "closed_at": null, "merged_at": null, "merge_commit_sha": "b584f06079f4d4dc10fbc0e9bbef848b5aeb0d15", "assignee": { "login": "SimonSapin", "id": 291359, "avatar_url": "https://avatars0.githubusercontent.com/u/291359?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SimonSapin", "html_url": "https://github.com/SimonSapin", "followers_url": "https://api.github.com/users/SimonSapin/followers", "following_url": "https://api.github.com/users/SimonSapin/following{/other_user}", "gists_url": "https://api.github.com/users/SimonSapin/gists{/gist_id}", "starred_url": "https://api.github.com/users/SimonSapin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SimonSapin/subscriptions", "organizations_url": "https://api.github.com/users/SimonSapin/orgs", "repos_url": "https://api.github.com/users/SimonSapin/repos", "events_url": "https://api.github.com/users/SimonSapin/events{/privacy}", "received_events_url": "https://api.github.com/users/SimonSapin/received_events", "type": "User", "site_admin": false }, "assignees": [ { "login": "SimonSapin", "id": 291359, "avatar_url": "https://avatars0.githubusercontent.com/u/291359?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SimonSapin", "html_url": "https://github.com/SimonSapin", "followers_url": "https://api.github.com/users/SimonSapin/followers", "following_url": "https://api.github.com/users/SimonSapin/following{/other_user}", "gists_url": "https://api.github.com/users/SimonSapin/gists{/gist_id}", "starred_url": "https://api.github.com/users/SimonSapin/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SimonSapin/subscriptions", "organizations_url": "https://api.github.com/users/SimonSapin/orgs", "repos_url": "https://api.github.com/users/SimonSapin/repos", "events_url": "https://api.github.com/users/SimonSapin/events{/privacy}", "received_events_url": "https://api.github.com/users/SimonSapin/received_events", "type": "User", "site_admin": false } ], "requested_reviewers": [ ], "milestone": null, "commits_url": "https://api.github.com/repos/servo/servo/pulls/19612/commits", "review_comments_url": "https://api.github.com/repos/servo/servo/pulls/19612/comments", "review_comment_url": "https://api.github.com/repos/servo/servo/pulls/comments{/number}", "comments_url": "https://api.github.com/repos/servo/servo/issues/19612/comments", "statuses_url": "https://api.github.com/repos/servo/servo/statuses/ab19bd1b6438c8e3aa0e5ab36dc3a6d5b14c12dd", "head": { "label": "tigercosmos:o1", "ref": "o1", "sha": "ab19bd1b6438c8e3aa0e5ab36dc3a6d5b14c12dd", "user": { "login": "tigercosmos", "id": 18013815, "avatar_url": "https://avatars0.githubusercontent.com/u/18013815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tigercosmos", "html_url": "https://github.com/tigercosmos", "followers_url": "https://api.github.com/users/tigercosmos/followers", "following_url": "https://api.github.com/users/tigercosmos/following{/other_user}", "gists_url": "https://api.github.com/users/tigercosmos/gists{/gist_id}", "starred_url": "https://api.github.com/users/tigercosmos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tigercosmos/subscriptions", "organizations_url": "https://api.github.com/users/tigercosmos/orgs", "repos_url": "https://api.github.com/users/tigercosmos/repos", "events_url": "https://api.github.com/users/tigercosmos/events{/privacy}", "received_events_url": "https://api.github.com/users/tigercosmos/received_events", "type": "User", "site_admin": false }, "repo": { "id": 100714943, "name": "servo", "full_name": "tigercosmos/servo", "owner": { "login": "tigercosmos", "id": 18013815, "avatar_url": "https://avatars0.githubusercontent.com/u/18013815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tigercosmos", "html_url": "https://github.com/tigercosmos", "followers_url": "https://api.github.com/users/tigercosmos/followers", "following_url": "https://api.github.com/users/tigercosmos/following{/other_user}", "gists_url": "https://api.github.com/users/tigercosmos/gists{/gist_id}", "starred_url": "https://api.github.com/users/tigercosmos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tigercosmos/subscriptions", "organizations_url": "https://api.github.com/users/tigercosmos/orgs", "repos_url": "https://api.github.com/users/tigercosmos/repos", "events_url": "https://api.github.com/users/tigercosmos/events{/privacy}", "received_events_url": "https://api.github.com/users/tigercosmos/received_events", "type": "User", "site_admin": false }, "private": false, "html_url": "https://github.com/tigercosmos/servo", "description": "The Servo Browser Engine", "fork": true, "url": "https://api.github.com/repos/tigercosmos/servo", "forks_url": "https://api.github.com/repos/tigercosmos/servo/forks", "keys_url": "https://api.github.com/repos/tigercosmos/servo/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/tigercosmos/servo/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/tigercosmos/servo/teams", "hooks_url": "https://api.github.com/repos/tigercosmos/servo/hooks", "issue_events_url": "https://api.github.com/repos/tigercosmos/servo/issues/events{/number}", "events_url": "https://api.github.com/repos/tigercosmos/servo/events", "assignees_url": "https://api.github.com/repos/tigercosmos/servo/assignees{/user}", "branches_url": "https://api.github.com/repos/tigercosmos/servo/branches{/branch}", "tags_url": "https://api.github.com/repos/tigercosmos/servo/tags", "blobs_url": "https://api.github.com/repos/tigercosmos/servo/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/tigercosmos/servo/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/tigercosmos/servo/git/refs{/sha}", "trees_url": "https://api.github.com/repos/tigercosmos/servo/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/tigercosmos/servo/statuses/{sha}", "languages_url": "https://api.github.com/repos/tigercosmos/servo/languages", "stargazers_url": "https://api.github.com/repos/tigercosmos/servo/stargazers", "contributors_url": "https://api.github.com/repos/tigercosmos/servo/contributors", "subscribers_url": "https://api.github.com/repos/tigercosmos/servo/subscribers", "subscription_url": "https://api.github.com/repos/tigercosmos/servo/subscription", "commits_url": "https://api.github.com/repos/tigercosmos/servo/commits{/sha}", "git_commits_url": "https://api.github.com/repos/tigercosmos/servo/git/commits{/sha}", "comments_url": "https://api.github.com/repos/tigercosmos/servo/comments{/number}", "issue_comment_url": "https://api.github.com/repos/tigercosmos/servo/issues/comments{/number}", "contents_url": "https://api.github.com/repos/tigercosmos/servo/contents/{+path}", "compare_url": "https://api.github.com/repos/tigercosmos/servo/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/tigercosmos/servo/merges", "archive_url": "https://api.github.com/repos/tigercosmos/servo/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/tigercosmos/servo/downloads", "issues_url": "https://api.github.com/repos/tigercosmos/servo/issues{/number}", "pulls_url": "https://api.github.com/repos/tigercosmos/servo/pulls{/number}", "milestones_url": "https://api.github.com/repos/tigercosmos/servo/milestones{/number}", "notifications_url": "https://api.github.com/repos/tigercosmos/servo/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/tigercosmos/servo/labels{/name}", "releases_url": "https://api.github.com/repos/tigercosmos/servo/releases{/id}", "deployments_url": "https://api.github.com/repos/tigercosmos/servo/deployments", "created_at": "2017-08-18T13:31:45Z", "updated_at": "2017-11-05T13:18:26Z", "pushed_at": "2017-12-21T13:34:10Z", "git_url": "git://github.com/tigercosmos/servo.git", "ssh_url": "git@github.com:tigercosmos/servo.git", "clone_url": "https://github.com/tigercosmos/servo.git", "svn_url": "https://github.com/tigercosmos/servo", "homepage": "https://servo.org/", "size": 321860, "stargazers_count": 0, "watchers_count": 0, "language": "Rust", "has_issues": false, "has_projects": true, "has_downloads": true, "has_wiki": true, "has_pages": false, "forks_count": 0, "mirror_url": null, "archived": false, "open_issues_count": 0, "license": { "key": "mpl-2.0", "name": "Mozilla Public License 2.0", "spdx_id": "MPL-2.0", "url": "https://api.github.com/licenses/mpl-2.0" }, "forks": 0, "open_issues": 0, "watchers": 0, "default_branch": "master" } }, "base": { "label": "servo:master", "ref": "master", "sha": "df0f9ad7ae6f10ffeaf5d40f4a2a25abadabf9cc", "user": { "login": "servo", "id": 2566135, "avatar_url": "https://avatars1.githubusercontent.com/u/2566135?v=4", "gravatar_id": "", "url": "https://api.github.com/users/servo", "html_url": "https://github.com/servo", "followers_url": "https://api.github.com/users/servo/followers", "following_url": "https://api.github.com/users/servo/following{/other_user}", "gists_url": "https://api.github.com/users/servo/gists{/gist_id}", "starred_url": "https://api.github.com/users/servo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/servo/subscriptions", "organizations_url": "https://api.github.com/users/servo/orgs", "repos_url": "https://api.github.com/users/servo/repos", "events_url": "https://api.github.com/users/servo/events{/privacy}", "received_events_url": "https://api.github.com/users/servo/received_events", "type": "Organization", "site_admin": false }, "repo": { "id": 3390243, "name": "servo", "full_name": "servo/servo", "owner": { "login": "servo", "id": 2566135, "avatar_url": "https://avatars1.githubusercontent.com/u/2566135?v=4", "gravatar_id": "", "url": "https://api.github.com/users/servo", "html_url": "https://github.com/servo", "followers_url": "https://api.github.com/users/servo/followers", "following_url": "https://api.github.com/users/servo/following{/other_user}", "gists_url": "https://api.github.com/users/servo/gists{/gist_id}", "starred_url": "https://api.github.com/users/servo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/servo/subscriptions", "organizations_url": "https://api.github.com/users/servo/orgs", "repos_url": "https://api.github.com/users/servo/repos", "events_url": "https://api.github.com/users/servo/events{/privacy}", "received_events_url": "https://api.github.com/users/servo/received_events", "type": "Organization", "site_admin": false }, "private": false, "html_url": "https://github.com/servo/servo", "description": "The Servo Browser Engine", "fork": false, "url": "https://api.github.com/repos/servo/servo", "forks_url": "https://api.github.com/repos/servo/servo/forks", "keys_url": "https://api.github.com/repos/servo/servo/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/servo/servo/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/servo/servo/teams", "hooks_url": "https://api.github.com/repos/servo/servo/hooks", "issue_events_url": "https://api.github.com/repos/servo/servo/issues/events{/number}", "events_url": "https://api.github.com/repos/servo/servo/events", "assignees_url": "https://api.github.com/repos/servo/servo/assignees{/user}", "branches_url": "https://api.github.com/repos/servo/servo/branches{/branch}", "tags_url": "https://api.github.com/repos/servo/servo/tags", "blobs_url": "https://api.github.com/repos/servo/servo/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/servo/servo/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/servo/servo/git/refs{/sha}", "trees_url": "https://api.github.com/repos/servo/servo/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/servo/servo/statuses/{sha}", "languages_url": "https://api.github.com/repos/servo/servo/languages", "stargazers_url": "https://api.github.com/repos/servo/servo/stargazers", "contributors_url": "https://api.github.com/repos/servo/servo/contributors", "subscribers_url": "https://api.github.com/repos/servo/servo/subscribers", "subscription_url": "https://api.github.com/repos/servo/servo/subscription", "commits_url": "https://api.github.com/repos/servo/servo/commits{/sha}", "git_commits_url": "https://api.github.com/repos/servo/servo/git/commits{/sha}", "comments_url": "https://api.github.com/repos/servo/servo/comments{/number}", "issue_comment_url": "https://api.github.com/repos/servo/servo/issues/comments{/number}", "contents_url": "https://api.github.com/repos/servo/servo/contents/{+path}", "compare_url": "https://api.github.com/repos/servo/servo/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/servo/servo/merges", "archive_url": "https://api.github.com/repos/servo/servo/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/servo/servo/downloads", "issues_url": "https://api.github.com/repos/servo/servo/issues{/number}", "pulls_url": "https://api.github.com/repos/servo/servo/pulls{/number}", "milestones_url": "https://api.github.com/repos/servo/servo/milestones{/number}", "notifications_url": "https://api.github.com/repos/servo/servo/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/servo/servo/labels{/name}", "releases_url": "https://api.github.com/repos/servo/servo/releases{/id}", "deployments_url": "https://api.github.com/repos/servo/servo/deployments", "created_at": "2012-02-08T19:07:25Z", "updated_at": "2017-12-21T09:43:03Z", "pushed_at": "2017-12-21T13:12:14Z", "git_url": "git://github.com/servo/servo.git", "ssh_url": "git@github.com:servo/servo.git", "clone_url": "https://github.com/servo/servo.git", "svn_url": "https://github.com/servo/servo", "homepage": "https://servo.org/", "size": 402429, "stargazers_count": 10867, "watchers_count": 10867, "language": "Rust", "has_issues": true, "has_projects": false, "has_downloads": true, "has_wiki": true, "has_pages": false, "forks_count": 1810, "mirror_url": null, "archived": false, "open_issues_count": 2027, "license": { "key": "mpl-2.0", "name": "Mozilla Public License 2.0", "spdx_id": "MPL-2.0", "url": "https://api.github.com/licenses/mpl-2.0" }, "forks": 1810, "open_issues": 2027, "watchers": 10867, "default_branch": "master" } }, "_links": { "self": { "href": "https://api.github.com/repos/servo/servo/pulls/19612" }, "html": { "href": "https://github.com/servo/servo/pull/19612" }, "issue": { "href": "https://api.github.com/repos/servo/servo/issues/19612" }, "comments": { "href": "https://api.github.com/repos/servo/servo/issues/19612/comments" }, "review_comments": { "href": "https://api.github.com/repos/servo/servo/pulls/19612/comments" }, "review_comment": { "href": "https://api.github.com/repos/servo/servo/pulls/comments{/number}" }, "commits": { "href": "https://api.github.com/repos/servo/servo/pulls/19612/commits" }, "statuses": { "href": "https://api.github.com/repos/servo/servo/statuses/ab19bd1b6438c8e3aa0e5ab36dc3a6d5b14c12dd" } }, "author_association": "CONTRIBUTOR", "merged": false, "mergeable": null, "rebaseable": null, "mergeable_state": "unknown", "merged_by": null, "comments": 61, "review_comments": 0, "maintainer_can_modify": true, "commits": 1, "additions": 19, "deletions": 20, "changed_files": 8 }, "before": "537b653d9044d2f265d5790ba3761cea539a57f6", "after": "ab19bd1b6438c8e3aa0e5ab36dc3a6d5b14c12dd", "repository": { "id": 3390243, "name": "servo", "full_name": "servo/servo", "owner": { "login": "servo", "id": 2566135, "avatar_url": "https://avatars1.githubusercontent.com/u/2566135?v=4", "gravatar_id": "", "url": "https://api.github.com/users/servo", "html_url": "https://github.com/servo", "followers_url": "https://api.github.com/users/servo/followers", "following_url": "https://api.github.com/users/servo/following{/other_user}", "gists_url": "https://api.github.com/users/servo/gists{/gist_id}", "starred_url": "https://api.github.com/users/servo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/servo/subscriptions", "organizations_url": "https://api.github.com/users/servo/orgs", "repos_url": "https://api.github.com/users/servo/repos", "events_url": "https://api.github.com/users/servo/events{/privacy}", "received_events_url": "https://api.github.com/users/servo/received_events", "type": "Organization", "site_admin": false }, "private": false, "html_url": "https://github.com/servo/servo", "description": "The Servo Browser Engine", "fork": false, "url": "https://api.github.com/repos/servo/servo", "forks_url": "https://api.github.com/repos/servo/servo/forks", "keys_url": "https://api.github.com/repos/servo/servo/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/servo/servo/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/servo/servo/teams", "hooks_url": "https://api.github.com/repos/servo/servo/hooks", "issue_events_url": "https://api.github.com/repos/servo/servo/issues/events{/number}", "events_url": "https://api.github.com/repos/servo/servo/events", "assignees_url": "https://api.github.com/repos/servo/servo/assignees{/user}", "branches_url": "https://api.github.com/repos/servo/servo/branches{/branch}", "tags_url": "https://api.github.com/repos/servo/servo/tags", "blobs_url": "https://api.github.com/repos/servo/servo/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/servo/servo/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/servo/servo/git/refs{/sha}", "trees_url": "https://api.github.com/repos/servo/servo/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/servo/servo/statuses/{sha}", "languages_url": "https://api.github.com/repos/servo/servo/languages", "stargazers_url": "https://api.github.com/repos/servo/servo/stargazers", "contributors_url": "https://api.github.com/repos/servo/servo/contributors", "subscribers_url": "https://api.github.com/repos/servo/servo/subscribers", "subscription_url": "https://api.github.com/repos/servo/servo/subscription", "commits_url": "https://api.github.com/repos/servo/servo/commits{/sha}", "git_commits_url": "https://api.github.com/repos/servo/servo/git/commits{/sha}", "comments_url": "https://api.github.com/repos/servo/servo/comments{/number}", "issue_comment_url": "https://api.github.com/repos/servo/servo/issues/comments{/number}", "contents_url": "https://api.github.com/repos/servo/servo/contents/{+path}", "compare_url": "https://api.github.com/repos/servo/servo/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/servo/servo/merges", "archive_url": "https://api.github.com/repos/servo/servo/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/servo/servo/downloads", "issues_url": "https://api.github.com/repos/servo/servo/issues{/number}", "pulls_url": "https://api.github.com/repos/servo/servo/pulls{/number}", "milestones_url": "https://api.github.com/repos/servo/servo/milestones{/number}", "notifications_url": "https://api.github.com/repos/servo/servo/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/servo/servo/labels{/name}", "releases_url": "https://api.github.com/repos/servo/servo/releases{/id}", "deployments_url": "https://api.github.com/repos/servo/servo/deployments", "created_at": "2012-02-08T19:07:25Z", "updated_at": "2017-12-21T09:43:03Z", "pushed_at": "2017-12-21T13:12:14Z", "git_url": "git://github.com/servo/servo.git", "ssh_url": "git@github.com:servo/servo.git", "clone_url": "https://github.com/servo/servo.git", "svn_url": "https://github.com/servo/servo", "homepage": "https://servo.org/", "size": 402429, "stargazers_count": 10867, "watchers_count": 10867, "language": "Rust", "has_issues": true, "has_projects": false, "has_downloads": true, "has_wiki": true, "has_pages": false, "forks_count": 1810, "mirror_url": null, "archived": false, "open_issues_count": 2027, "license": { "key": "mpl-2.0", "name": "Mozilla Public License 2.0", "spdx_id": "MPL-2.0", "url": "https://api.github.com/licenses/mpl-2.0" }, "forks": 1810, "open_issues": 2027, "watchers": 10867, "default_branch": "master" }, "organization": { "login": "servo", "id": 2566135, "url": "https://api.github.com/orgs/servo", "repos_url": "https://api.github.com/orgs/servo/repos", "events_url": "https://api.github.com/orgs/servo/events", "hooks_url": "https://api.github.com/orgs/servo/hooks", "issues_url": "https://api.github.com/orgs/servo/issues", "members_url": "https://api.github.com/orgs/servo/members{/member}", "public_members_url": "https://api.github.com/orgs/servo/public_members{/member}", "avatar_url": "https://avatars1.githubusercontent.com/u/2566135?v=4", "description": "The Servo web browser engine" }, "sender": { "login": "tigercosmos", "id": 18013815, "avatar_url": "https://avatars0.githubusercontent.com/u/18013815?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tigercosmos", "html_url": "https://github.com/tigercosmos", "followers_url": "https://api.github.com/users/tigercosmos/followers", "following_url": "https://api.github.com/users/tigercosmos/following{/other_user}", "gists_url": "https://api.github.com/users/tigercosmos/gists{/gist_id}", "starred_url": "https://api.github.com/users/tigercosmos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tigercosmos/subscriptions", "organizations_url": "https://api.github.com/users/tigercosmos/orgs", "repos_url": "https://api.github.com/users/tigercosmos/repos", "events_url": "https://api.github.com/users/tigercosmos/events{/privacy}", "received_events_url": "https://api.github.com/users/tigercosmos/received_events", "type": "User", "site_admin": false } }