From 394f8163433559cea294cb4a4e335cc43ccde1fe Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Mon, 19 Jan 2015 13:40:29 +0100 Subject: Disallow lines that span more than 160 columns. The Rust style guide suggests 100, but we have too many violations in the tree already. This check can be tightened over time. --- python/tidy.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'python/tidy.py') diff --git a/python/tidy.py b/python/tidy.py index da930eea333..fc282aaa464 100644 --- a/python/tidy.py +++ b/python/tidy.py @@ -56,6 +56,13 @@ def check_license(contents): yield (1, "incorrect license") +def check_length(contents): + lines = contents.splitlines(True) + for idx, line in enumerate(lines): + if len(line) >= 160: + yield (idx + 1, "(much) overlong line") + + def check_whitespace(contents): lines = contents.splitlines(True) for idx, line in enumerate(lines): @@ -88,7 +95,7 @@ def scan(): all_files = collect_file_names(directories_to_check) files_to_check = filter(should_check, all_files) - checking_functions = [check_license, check_whitespace] + checking_functions = [check_license, check_length, check_whitespace] errors = collect_errors_for_files(files_to_check, checking_functions) errors = list(errors) -- cgit v1.2.3