From e69fbc22ded53228681cdfb1bfdbb27f8727efb2 Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Mon, 15 Sep 2014 08:31:43 -0700 Subject: Don't throw on non-zero exit in mach commands Fixes #3344. --- python/servo/build_commands.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'python/servo/build_commands.py') diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index 14553082e35..3b34e575443 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -50,10 +50,11 @@ class MachCommands(CommandBase): opts += ["-v"] build_start = time() - subprocess.check_call(["cargo", "build"] + opts, env=self.build_env()) + status = subprocess.call(["cargo", "build"] + opts, env=self.build_env()) elapsed = time() - build_start print("Build completed in %0.2fs" % elapsed) + return status @Command('build-cef', description='Build the Chromium Embedding Framework library', @@ -89,7 +90,7 @@ class MachCommands(CommandBase): opts = [] if jobs is not None: opts += ["-j", jobs] - subprocess.check_call(["cargo", "test", "--no-run"], env=self.build_env()) + return subprocess.call(["cargo", "test", "--no-run"], env=self.build_env()) @Command('clean', description='Clean the build directory.', @@ -109,4 +110,4 @@ class MachCommands(CommandBase): if verbose: opts += ["-v"] - subprocess.check_call(["cargo", "clean"] + opts, env=self.build_env()) + return subprocess.call(["cargo", "clean"] + opts, env=self.build_env()) -- cgit v1.2.3