From df71aa2f1ef738c8970cdaae63ec15363163137c Mon Sep 17 00:00:00 2001 From: Mukilan Thiyagarajan Date: Sun, 21 May 2023 11:33:22 +0530 Subject: Avoid relinking plugin dylibs The `copy_dependencies` logic is invoking `change_non_system_libraries_path` with absolute paths to gstreamer *plugin dylibs*. `change_non_system_libraries_path` skips editing links in servo binary to relocatable dylibs, but the since the plugins have absolute paths, they are treated as 'non-relocable' and it will try to edit the *non-existent* (since plugins are loaded dynamically) link in servo bin. These unnecessary calls to change_link_name is cause of the slowness identified in #29764 This PR fixes the issue by ensuring plugins are not included in the call to change_non_system_libraries_path Signed-off-by: Mukilan Thiyagarajan --- python/servo/build_commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'python/servo/build_commands.py') diff --git a/python/servo/build_commands.py b/python/servo/build_commands.py index 1f69637ad85..ed018029349 100644 --- a/python/servo/build_commands.py +++ b/python/servo/build_commands.py @@ -858,8 +858,8 @@ def copy_dependencies(binary_path, lib_path, gst_root): # Update binary libraries binary_dependencies = set(otool(binary_path)) - binary_dependencies = binary_dependencies.union(macos_plugins()) change_non_system_libraries_path(binary_dependencies, relative_path, binary_path) + binary_dependencies = binary_dependencies.union(macos_plugins()) # Update dependencies libraries need_checked = binary_dependencies -- cgit v1.2.3