From 8882507ad06b598fb43d8542c67ad76daeda739c Mon Sep 17 00:00:00 2001 From: Delan Azabani Date: Fri, 22 Mar 2024 14:06:28 +0800 Subject: =?UTF-8?q?Rework=20=E2=80=9Cvisible=E2=80=9D=20to=20=E2=80=9Cthro?= =?UTF-8?q?ttled=E2=80=9D=20in=20constellation=20+=20script=20+=20composit?= =?UTF-8?q?or=20(#31816)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- components/shared/script/lib.rs | 13 ++++++------- components/shared/script/script_msg.rs | 6 +++--- 2 files changed, 9 insertions(+), 10 deletions(-) (limited to 'components/shared/script') diff --git a/components/shared/script/lib.rs b/components/shared/script/lib.rs index 071efd92a02..76d0e74bd31 100644 --- a/components/shared/script/lib.rs +++ b/components/shared/script/lib.rs @@ -312,11 +312,10 @@ pub enum ConstellationControlMsg { GetTitle(PipelineId), /// Notifies script thread of a change to one of its document's activity SetDocumentActivity(PipelineId, DocumentActivity), - /// Notifies script thread whether frame is visible - ChangeFrameVisibilityStatus(PipelineId, bool), - /// Notifies script thread that frame visibility change is complete - /// PipelineId is for the parent, BrowsingContextId is for the nested browsing context - NotifyVisibilityChange(PipelineId, BrowsingContextId, bool), + /// Set whether to use less resources by running timers at a heavily limited rate. + SetThrottled(PipelineId, bool), + /// Notify the containing iframe (in PipelineId) that the nested browsing context (BrowsingContextId) is throttled. + SetThrottledInContainingIframe(PipelineId, BrowsingContextId, bool), /// Notifies script thread that a url should be loaded in this iframe. /// PipelineId is for the parent, BrowsingContextId is for the nested browsing context NavigateIframe( @@ -416,8 +415,8 @@ impl fmt::Debug for ConstellationControlMsg { SetScrollState(..) => "SetScrollState", GetTitle(..) => "GetTitle", SetDocumentActivity(..) => "SetDocumentActivity", - ChangeFrameVisibilityStatus(..) => "ChangeFrameVisibilityStatus", - NotifyVisibilityChange(..) => "NotifyVisibilityChange", + SetThrottled(..) => "SetThrottled", + SetThrottledInContainingIframe(..) => "SetThrottledInContainingIframe", NavigateIframe(..) => "NavigateIframe", PostMessage { .. } => "PostMessage", UpdatePipelineId(..) => "UpdatePipelineId", diff --git a/components/shared/script/script_msg.rs b/components/shared/script/script_msg.rs index cc569653dcd..ff854b8d26f 100644 --- a/components/shared/script/script_msg.rs +++ b/components/shared/script/script_msg.rs @@ -215,8 +215,8 @@ pub enum ScriptMsg { /// Notification that this iframe should be removed. /// Returns a list of pipelines which were closed. RemoveIFrame(BrowsingContextId, IpcSender>), - /// Notifies constellation that an iframe's visibility has been changed. - VisibilityChangeComplete(bool), + /// Successful response to [crate::ConstellationControlMsg::SetThrottled]. + SetThrottledComplete(bool), /// A load has been requested in an IFrame. ScriptLoadedURLInIFrame(IFrameLoadInfoWithData), /// A load of the initial `about:blank` has been completed in an IFrame. @@ -304,7 +304,7 @@ impl fmt::Debug for ScriptMsg { ReplaceHistoryState(..) => "ReplaceHistoryState", JointSessionHistoryLength(..) => "JointSessionHistoryLength", RemoveIFrame(..) => "RemoveIFrame", - VisibilityChangeComplete(..) => "VisibilityChangeComplete", + SetThrottledComplete(..) => "SetThrottledComplete", ScriptLoadedURLInIFrame(..) => "ScriptLoadedURLInIFrame", ScriptNewIFrame(..) => "ScriptNewIFrame", ScriptNewAuxiliary(..) => "ScriptNewAuxiliary", -- cgit v1.2.3