From 9195344b75b4e5fd1cd86671b10df46a956f0fea Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Wed, 9 Oct 2024 10:30:24 -0700 Subject: compositor: Create a single cross-process compositor API (#33619) (#33660) Instead of exposing many different kinds of messages to the compositor that are routed through the constellation, expose a single message type which can be sent across IPC channels. In addition, this IPC channel and the route to the crossbeam channel with the compositor is created along with the `CompositorProxy`, simplifying what needs to be passed around during pipeline initialization. Previously, some image updates (from video) were sent over IPC with a special serialization routine and some were sent via crossbeam channels (canvas). Now all updates go over the IPC channel `IpcSharedMemory` is used to avoid serialization penalties. This should improve performance and reduce copies for video, but add a memory copy overhead for canvas. This will improve in the future when canvas renders directly into a texture. All-in-all this is a simplification which opens the path toward having a standard compositor API and reduces the number of duplicate messages and proxying that had to happen in libservo. Signed-off-by: Martin Robinson --- components/shared/script/script_msg.rs | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'components/shared/script/script_msg.rs') diff --git a/components/shared/script/script_msg.rs b/components/shared/script/script_msg.rs index ee8e8da1386..5689395ef32 100644 --- a/components/shared/script/script_msg.rs +++ b/components/shared/script/script_msg.rs @@ -24,7 +24,6 @@ use serde::{Deserialize, Serialize}; use servo_url::{ImmutableOrigin, ServoUrl}; use style_traits::CSSPixel; use webgpu::{wgc, WebGPU, WebGPUResponse}; -use webrender_api::units::{DeviceIntPoint, DeviceIntSize}; use crate::{ AnimationState, AuxiliaryBrowsingContextLoadInfo, BroadcastMsg, DocumentState, @@ -245,12 +244,6 @@ pub enum ScriptMsg { ForwardDOMMessage(DOMMessage, ServoUrl), /// ScheduleJob(Job), - /// Get Window Informations size and position - GetClientWindow(IpcSender<(DeviceIntSize, DeviceIntPoint)>), - /// Get the screen size (pixel) - GetScreenSize(IpcSender), - /// Get the available screen size (pixel) - GetScreenAvailSize(IpcSender), /// Notifies the constellation about media session events /// (i.e. when there is metadata for the active media session, playback state changes...). MediaSessionEvent(PipelineId, MediaSessionEvent), @@ -318,9 +311,6 @@ impl fmt::Debug for ScriptMsg { PipelineExited => "PipelineExited", ForwardDOMMessage(..) => "ForwardDOMMessage", ScheduleJob(..) => "ScheduleJob", - GetClientWindow(..) => "GetClientWindow", - GetScreenSize(..) => "GetScreenSize", - GetScreenAvailSize(..) => "GetScreenAvailSize", MediaSessionEvent(..) => "MediaSessionEvent", RequestAdapter(..) => "RequestAdapter", GetWebGPUChan(..) => "GetWebGPUChan", -- cgit v1.2.3