From b5d51dd2636935471447fc741ffbb95c62e37f94 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Sat, 30 Sep 2017 15:50:47 +0200 Subject: Switch to using WebRender hit testing This trades quite a bit of complicated code in Servo for few more messages and a significant performance improvement. In particular, WebRender can search the entire display list at once instead of ping-ponging down the pipeline tree. This allows us to send mouse events to the correct pipeline immediately. --- components/script_layout_interface/message.rs | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) (limited to 'components/script_layout_interface/message.rs') diff --git a/components/script_layout_interface/message.rs b/components/script_layout_interface/message.rs index a026b349ab8..6f8009ecdd8 100644 --- a/components/script_layout_interface/message.rs +++ b/components/script_layout_interface/message.rs @@ -100,6 +100,11 @@ pub enum Msg { SetNavigationStart(f64), } +#[derive(Debug, PartialEq)] +pub enum NodesFromPointQueryType { + All, + Topmost, +} /// Any query to perform with this reflow. #[derive(Debug, PartialEq)] @@ -109,7 +114,6 @@ pub enum ReflowGoal { ContentBoxQuery(TrustedNodeAddress), ContentBoxesQuery(TrustedNodeAddress), NodeOverflowQuery(TrustedNodeAddress), - HitTestQuery(Point2D, bool), NodeScrollRootIdQuery(TrustedNodeAddress), NodeGeometryQuery(TrustedNodeAddress), NodeScrollGeometryQuery(TrustedNodeAddress), @@ -117,7 +121,7 @@ pub enum ReflowGoal { OffsetParentQuery(TrustedNodeAddress), MarginStyleQuery(TrustedNodeAddress), TextIndexQuery(TrustedNodeAddress, i32, i32), - NodesFromPoint(Point2D), + NodesFromPointQuery(Point2D, NodesFromPointQueryType), } impl ReflowGoal { @@ -125,9 +129,8 @@ impl ReflowGoal { /// be present or false if it only needs stacking-relative positions. pub fn needs_display_list(&self) -> bool { match *self { - ReflowGoal::NodesFromPoint(..) | ReflowGoal::HitTestQuery(..) | - ReflowGoal::TextIndexQuery(..) | ReflowGoal::TickAnimations | - ReflowGoal::Full => true, + ReflowGoal::NodesFromPointQuery(..) | ReflowGoal::TextIndexQuery(..) | + ReflowGoal::TickAnimations | ReflowGoal::Full => true, ReflowGoal::ContentBoxQuery(_) | ReflowGoal::ContentBoxesQuery(_) | ReflowGoal::NodeGeometryQuery(_) | ReflowGoal::NodeScrollGeometryQuery(_) | ReflowGoal::NodeOverflowQuery(_) | ReflowGoal::NodeScrollRootIdQuery(_) | @@ -141,12 +144,13 @@ impl ReflowGoal { pub fn needs_display(&self) -> bool { match *self { ReflowGoal::MarginStyleQuery(_) | ReflowGoal::TextIndexQuery(..) | - ReflowGoal::HitTestQuery(..) | ReflowGoal::ContentBoxQuery(_) | - ReflowGoal::ContentBoxesQuery(_) | ReflowGoal::NodeGeometryQuery(_) | - ReflowGoal::NodeScrollGeometryQuery(_) | ReflowGoal::NodeOverflowQuery(_) | - ReflowGoal::NodeScrollRootIdQuery(_) | ReflowGoal::ResolvedStyleQuery(..) | - ReflowGoal::OffsetParentQuery(_) | ReflowGoal::NodesFromPoint(..) => false, - ReflowGoal::Full | ReflowGoal::TickAnimations => true, + ReflowGoal::ContentBoxQuery(_) | ReflowGoal::ContentBoxesQuery(_) | + ReflowGoal::NodeGeometryQuery(_) | ReflowGoal::NodeScrollGeometryQuery(_) | + ReflowGoal::NodeOverflowQuery(_) | ReflowGoal::NodeScrollRootIdQuery(_) | + ReflowGoal::ResolvedStyleQuery(..) | + ReflowGoal::OffsetParentQuery(_) => false, + ReflowGoal::NodesFromPointQuery(..) | ReflowGoal::Full | + ReflowGoal::TickAnimations => true, } } } -- cgit v1.2.3