From 77cfca65c441ff1f8b54a507c9802e7ae6893e62 Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Wed, 1 Jan 2025 14:50:52 +0100 Subject: script: Eliminate code duplication in the task queue (#34798) Instead of creating a type for each `TaskSource` variety have each `TaskSource` hold the same kind of sender (this was inconsistent before, but each sender was effectively the same trait object), a pipeline, and a `TaskSourceName`. This elminates the need to reimplement the same queuing code for every task source. In addition, have workers hold their own `TaskManager`. This allows just exposing the manager on the `GlobalScope`. Currently the `TaskCanceller` is different, but this will also be eliminated in a followup change. This is a the first step toward having a shared set of `Sender`s on `GlobalScope`. Signed-off-by: Martin Robinson --- components/script/dom/webxr/fakexrdevice.rs | 1 - components/script/dom/webxr/xrsession.rs | 1 - components/script/dom/webxr/xrsystem.rs | 1 - components/script/dom/webxr/xrtest.rs | 1 - 4 files changed, 4 deletions(-) (limited to 'components/script/dom/webxr') diff --git a/components/script/dom/webxr/fakexrdevice.rs b/components/script/dom/webxr/fakexrdevice.rs index 194ba0bd087..04440086f90 100644 --- a/components/script/dom/webxr/fakexrdevice.rs +++ b/components/script/dom/webxr/fakexrdevice.rs @@ -35,7 +35,6 @@ use crate::dom::fakexrinputcontroller::{init_to_mock_buttons, FakeXRInputControl use crate::dom::globalscope::GlobalScope; use crate::dom::promise::Promise; use crate::script_runtime::CanGc; -use crate::task_source::TaskSource; #[dom_struct] pub struct FakeXRDevice { diff --git a/components/script/dom/webxr/xrsession.rs b/components/script/dom/webxr/xrsession.rs index 92ac419c585..f3b8a3ce32c 100644 --- a/components/script/dom/webxr/xrsession.rs +++ b/components/script/dom/webxr/xrsession.rs @@ -68,7 +68,6 @@ use crate::dom::xrsessionevent::XRSessionEvent; use crate::dom::xrspace::XRSpace; use crate::realms::InRealm; use crate::script_runtime::JSContext; -use crate::task_source::TaskSource; use crate::script_runtime::CanGc; #[dom_struct] diff --git a/components/script/dom/webxr/xrsystem.rs b/components/script/dom/webxr/xrsystem.rs index fb28b477e39..82bf4e5d37e 100644 --- a/components/script/dom/webxr/xrsystem.rs +++ b/components/script/dom/webxr/xrsystem.rs @@ -35,7 +35,6 @@ use crate::dom::xrtest::XRTest; use crate::realms::InRealm; use crate::script_runtime::CanGc; use crate::script_thread::ScriptThread; -use crate::task_source::TaskSource; #[dom_struct] pub struct XRSystem { diff --git a/components/script/dom/webxr/xrtest.rs b/components/script/dom/webxr/xrtest.rs index 02c090b2a1f..b56049b6dff 100644 --- a/components/script/dom/webxr/xrtest.rs +++ b/components/script/dom/webxr/xrtest.rs @@ -28,7 +28,6 @@ use crate::dom::globalscope::GlobalScope; use crate::dom::promise::Promise; use crate::script_runtime::CanGc; use crate::script_thread::ScriptThread; -use crate::task_source::TaskSource; #[dom_struct] pub struct XRTest { -- cgit v1.2.3