From 0e3c54c1911ba2c3bf305ee04f04fcd9bf2fc2fe Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Mon, 25 Sep 2017 23:30:24 +0200 Subject: Rename dom::bindings::js to dom::bindings::root --- components/script/dom/processinginstruction.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index 31e6737a977..c70e191976e 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -4,7 +4,7 @@ use dom::bindings::codegen::Bindings::ProcessingInstructionBinding; use dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; -use dom::bindings::js::Root; +use dom::bindings::root::Root; use dom::bindings::str::DOMString; use dom::characterdata::CharacterData; use dom::document::Document; -- cgit v1.2.3 From f87c2a8d7616112ca924e30292db2d244cf87eec Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Tue, 26 Sep 2017 01:53:40 +0200 Subject: Rename Root to DomRoot In a later PR, DomRoot will become a type alias of Root>, where Root will be able to handle all the things that need to be rooted that have a stable traceable address that doesn't move for the whole lifetime of the root. Stay tuned. --- components/script/dom/processinginstruction.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index c70e191976e..1cdb5eb1c4c 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -4,7 +4,7 @@ use dom::bindings::codegen::Bindings::ProcessingInstructionBinding; use dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; -use dom::bindings::root::Root; +use dom::bindings::root::DomRoot; use dom::bindings::str::DOMString; use dom::characterdata::CharacterData; use dom::document::Document; @@ -26,7 +26,7 @@ impl ProcessingInstruction { } } - pub fn new(target: DOMString, data: DOMString, document: &Document) -> Root { + pub fn new(target: DOMString, data: DOMString, document: &Document) -> DomRoot { Node::reflect_node(box ProcessingInstruction::new_inherited(target, data, document), document, ProcessingInstructionBinding::Wrap) } -- cgit v1.2.3 From aa15dc269f41503d81ad44cd7e85d69e6f4aeac7 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Mon, 16 Oct 2017 14:35:30 +0200 Subject: Remove use of unstable box syntax. http://www.robohornet.org gives a score of 101.36 on master, and 102.68 with this PR. The latter is slightly better, but probably within noise level. So it looks like this PR does not affect DOM performance. This is expected since `Box::new` is defined as: ```rust impl Box { #[inline(always)] pub fn new(x: T) -> Box { box x } } ``` With inlining, it should compile to the same as box syntax. --- components/script/dom/processinginstruction.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index 1cdb5eb1c4c..d4eee64d2aa 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -27,7 +27,7 @@ impl ProcessingInstruction { } pub fn new(target: DOMString, data: DOMString, document: &Document) -> DomRoot { - Node::reflect_node(box ProcessingInstruction::new_inherited(target, data, document), + Node::reflect_node(Box::new(ProcessingInstruction::new_inherited(target, data, document)), document, ProcessingInstructionBinding::Wrap) } } -- cgit v1.2.3 From c37a345dc9f4dda6ea29c42f96f6c7201c42cbac Mon Sep 17 00:00:00 2001 From: chansuke Date: Tue, 18 Sep 2018 23:24:15 +0900 Subject: Format script component --- components/script/dom/processinginstruction.rs | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index d4eee64d2aa..605a6210485 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -19,20 +19,30 @@ pub struct ProcessingInstruction { } impl ProcessingInstruction { - fn new_inherited(target: DOMString, data: DOMString, document: &Document) -> ProcessingInstruction { + fn new_inherited( + target: DOMString, + data: DOMString, + document: &Document, + ) -> ProcessingInstruction { ProcessingInstruction { characterdata: CharacterData::new_inherited(data, document), - target: target + target: target, } } - pub fn new(target: DOMString, data: DOMString, document: &Document) -> DomRoot { - Node::reflect_node(Box::new(ProcessingInstruction::new_inherited(target, data, document)), - document, ProcessingInstructionBinding::Wrap) + pub fn new( + target: DOMString, + data: DOMString, + document: &Document, + ) -> DomRoot { + Node::reflect_node( + Box::new(ProcessingInstruction::new_inherited(target, data, document)), + document, + ProcessingInstructionBinding::Wrap, + ) } } - impl ProcessingInstruction { pub fn target(&self) -> &DOMString { &self.target -- cgit v1.2.3 From 45f7199eee82c66637ec68287eafa40a651001c4 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Thu, 1 Nov 2018 23:45:06 +0100 Subject: `cargo fix --edition` --- components/script/dom/processinginstruction.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index 605a6210485..5be09ea452d 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -2,13 +2,13 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use dom::bindings::codegen::Bindings::ProcessingInstructionBinding; -use dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; -use dom::bindings::root::DomRoot; -use dom::bindings::str::DOMString; -use dom::characterdata::CharacterData; -use dom::document::Document; -use dom::node::Node; +use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding; +use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; +use crate::dom::bindings::root::DomRoot; +use crate::dom::bindings::str::DOMString; +use crate::dom::characterdata::CharacterData; +use crate::dom::document::Document; +use crate::dom::node::Node; use dom_struct::dom_struct; /// An HTML processing instruction node. -- cgit v1.2.3 From a1a14459c141afc6ac6771b8a6c9ca374537edf2 Mon Sep 17 00:00:00 2001 From: Jan Andre Ikenmeyer Date: Mon, 19 Nov 2018 14:47:12 +0100 Subject: Update MPL license to https (part 3) --- components/script/dom/processinginstruction.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index 5be09ea452d..3b01f71c0e0 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -1,6 +1,6 @@ /* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding; use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; -- cgit v1.2.3 From 3ea6d87bcc37167464e856949a4b9b77d0e9318a Mon Sep 17 00:00:00 2001 From: YUAN LYU Date: Fri, 20 Mar 2020 22:14:18 -0400 Subject: Add trait DomObjectWrap to provide WRAP function --- components/script/dom/processinginstruction.rs | 2 -- 1 file changed, 2 deletions(-) (limited to 'components/script/dom/processinginstruction.rs') diff --git a/components/script/dom/processinginstruction.rs b/components/script/dom/processinginstruction.rs index 3b01f71c0e0..9edbf1a0a29 100644 --- a/components/script/dom/processinginstruction.rs +++ b/components/script/dom/processinginstruction.rs @@ -2,7 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ -use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding; use crate::dom::bindings::codegen::Bindings::ProcessingInstructionBinding::ProcessingInstructionMethods; use crate::dom::bindings::root::DomRoot; use crate::dom::bindings::str::DOMString; @@ -38,7 +37,6 @@ impl ProcessingInstruction { Node::reflect_node( Box::new(ProcessingInstruction::new_inherited(target, data, document)), document, - ProcessingInstructionBinding::Wrap, ) } } -- cgit v1.2.3