From aa15dc269f41503d81ad44cd7e85d69e6f4aeac7 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Mon, 16 Oct 2017 14:35:30 +0200 Subject: Remove use of unstable box syntax. http://www.robohornet.org gives a score of 101.36 on master, and 102.68 with this PR. The latter is slightly better, but probably within noise level. So it looks like this PR does not affect DOM performance. This is expected since `Box::new` is defined as: ```rust impl Box { #[inline(always)] pub fn new(x: T) -> Box { box x } } ``` With inlining, it should compile to the same as box syntax. --- components/script/dom/htmlselectelement.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'components/script/dom/htmlselectelement.rs') diff --git a/components/script/dom/htmlselectelement.rs b/components/script/dom/htmlselectelement.rs index d9eba4dea72..75dea8d461e 100755 --- a/components/script/dom/htmlselectelement.rs +++ b/components/script/dom/htmlselectelement.rs @@ -84,7 +84,7 @@ impl HTMLSelectElement { pub fn new(local_name: LocalName, prefix: Option, document: &Document) -> DomRoot { - Node::reflect_node(box HTMLSelectElement::new_inherited(local_name, prefix, document), + Node::reflect_node(Box::new(HTMLSelectElement::new_inherited(local_name, prefix, document)), document, HTMLSelectElementBinding::Wrap) } @@ -247,7 +247,7 @@ impl HTMLSelectElementMethods for HTMLSelectElement { self.options.or_init(|| { let window = window_from_node(self); HTMLOptionsCollection::new( - &window, self, box OptionsFilter) + &window, self, Box::new(OptionsFilter)) }) } -- cgit v1.2.3