From 160c7c0b0f061afa1277fa56cdd1d898379a8223 Mon Sep 17 00:00:00 2001 From: Pi-Cla Date: Thu, 2 May 2024 14:02:21 -0600 Subject: Fix some clippy warnings in `components/gfx` and `components/script` (#32215) * clippy: Squish warnings and errors in gfx warning: redundant closure (gfx/font.rs:415:18) warning: useless conversion to the same type (gfx/font.rs:534:9) warning: the following explicit lifetimes could be elided: 'a (gfx/font.rs:619:16) error: this loop never actually loops (gfx/font_cache_thread.rs:112:9) warning: this expression creates a reference which is immediately dereferenced by the compiler (gfx/font_cache_thread.rs:229:51) warning: redundant closure (gfx/font_cache_thread.rs:551:18) 3 instances of: warning: casting integer literal to `f64` is unnecessary (gfx/platform/freetype/font_list.rs:271-273) * clippy: methods called `from_*` usually take no `self` It reports that by standard convention, from_* methods should not take any `&self` parameter * clippy: you should consider adding a `Default` implementation It reports that public types with a pub fn new() -> Self should have a Default implementation since they can be constructed without arguments * clippy: casting to the same type is unnecessary (`f32` -> `f32`) * clippy: use of `unwrap_or_else` to construct default value * clippy: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` * clippy: manual `!RangeInclusive::contains` implementation contains expresses the intent better and has less failure modes (such as fencepost errors or using || instead of &&) * clippy: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` * clippy: Fix some new warnings warning: this `if` statement can be collapsed (gfx/font.rs:468:130) warning: this lifetime isn't used in the impl (gfx/platform/freetype/font.rs:341:6) warning: field assignment outside of initializer for an instance created with Default::default() (compositor.rs:881:17) --- components/script/dom/bluetooth.rs | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'components/script/dom/bluetooth.rs') diff --git a/components/script/dom/bluetooth.rs b/components/script/dom/bluetooth.rs index 77ca187a671..7ae54893064 100644 --- a/components/script/dom/bluetooth.rs +++ b/components/script/dom/bluetooth.rs @@ -98,6 +98,12 @@ impl BluetoothExtraPermissionData { } } +impl Default for BluetoothExtraPermissionData { + fn default() -> Self { + Self::new() + } +} + struct BluetoothContext { promise: Option, receiver: Trusted, -- cgit v1.2.3