From 10296e77dc79f659f0382c62bfacdd6ff0f07cdc Mon Sep 17 00:00:00 2001 From: Corey Farwell Date: Sat, 11 Jul 2015 07:41:44 +0900 Subject: Use NotImplementedError for Python base class methods From the Python docs: https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError "In user defined base classes, abstract methods should raise this exception when they require derived classes to override the method." --- components/script/dom/bindings/codegen/CodegenRust.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'components/script/dom/bindings/codegen') diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index 8b7b427f689..3f77ddba8dd 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -272,7 +272,7 @@ class CGThing(): def define(self): """Produce code for a Rust file.""" - assert(False) # Override me! + raise NotImplementedError # Override me! class CGNativePropertyHooks(CGThing): @@ -2134,7 +2134,7 @@ class CGAbstractMethod(CGThing): return "\n}\n" def definition_body(self): - assert(False) # Override me! + raise NotImplementedError # Override me! def CreateBindingJSObject(descriptor, parent=None): @@ -2843,7 +2843,7 @@ let global = global_object_for_js_object(JS_CALLEE(cx, vp).to_object()); return CGList([preamble, self.generate_code()]) def generate_code(self): - assert False # Override me + raise NotImplementedError # Override me! class CGSpecializedMethod(CGAbstractExternMethod): @@ -4538,8 +4538,7 @@ let this: *const %s = native_from_reflector::<%s>(obj); ]) def generate_code(self): - # Override me - assert(False) + raise NotImplementedError # Override me! def finalizeHook(descriptor, hookName, context): -- cgit v1.2.3