From 4402b7cf8f56aa6e62a13dd1997b570e7331b72e Mon Sep 17 00:00:00 2001 From: Martin Robinson Date: Wed, 2 Apr 2025 00:59:50 +0200 Subject: libservo: Remove a couple `EmbedderMethods` (#36276) - Remove `EmbedderMethods::get_user_agent_string`. This is now part of the `Preferences` data structure, which should allow it to be per-`WebView` in the future. - Remove `EmbedderMethods::get_version_string`. This was used to include some data along with WebRender captures about the Servo version. This isn't really necessary and it was done to replace code in the past that output the WebRender version, so also isn't what the original code did. I think we can just remove this entirely. The idea with these changes is that `EmbedderMethods` can be removed in a followup and the rest of the methods can be added to `ServoDelegate`. These two methods are ones that cannot be added to a delegate as they are used during `Servo` initialization. Testing: There is currently no testing for libservo. These changes are meant as preparation for adding a suite of `WebView` unit tests. Signed-off-by: Martin Robinson Signed-off-by: Martin Robinson --- components/net/tests/resource_thread.rs | 1 - 1 file changed, 1 deletion(-) (limited to 'components/net/tests') diff --git a/components/net/tests/resource_thread.rs b/components/net/tests/resource_thread.rs index 0de76fd5dd1..05b8bbad640 100644 --- a/components/net/tests/resource_thread.rs +++ b/components/net/tests/resource_thread.rs @@ -25,7 +25,6 @@ fn test_exit() { let (mtx, _mrx) = ipc::channel().unwrap(); let (sender, receiver) = ipc::channel().unwrap(); let (resource_thread, _private_resource_thread) = new_core_resource_thread( - "".into(), None, ProfilerChan(tx), MemProfilerChan(mtx), -- cgit v1.2.3